On 02/09/2010 06:24 PM, malc wrote:
On Tue, 9 Feb 2010, Anthony Liguori wrote:
On 02/09/2010 05:36 PM, malc wrote:
Let's see:
Currently we have this
readb(...):
dostuff
return stuff
readw(...):
dostuff
return stuff
And this is completely wrong.
It
On Tue, 9 Feb 2010, Anthony Liguori wrote:
> On 02/09/2010 05:36 PM, malc wrote:
> > Let's see:
> >
> > Currently we have this
> >
> >
> > readb(...):
> >dostuff
> >return stuff
> >
> > readw(...):
> >dostuff
> >return stuff
> >
>
> And this is completely wrong.
It's comp
On 02/09/2010 05:36 PM, malc wrote:
Let's see:
Currently we have this
readb(...):
dostuff
return stuff
readw(...):
dostuff
return stuff
And this is completely wrong.
For the most part, device models don't consistently handle access to
registers via their non native sizes.
On Tue, 9 Feb 2010, Anthony Liguori wrote:
> On 02/09/2010 05:06 PM, malc wrote:
> >
> > > We already have this problem with the current interface.
> > >
> > Uh, i've meant the registration of one function to rule them all, instead
> > of how it's done currently - separate accessors for b/w
On 02/09/2010 05:06 PM, malc wrote:
We already have this problem with the current interface.
Uh, i've meant the registration of one function to rule them all, instead
of how it's done currently - separate accessors for b/w/l/whatever.
How does that make any difference? Both the io
On Tue, 9 Feb 2010, Anthony Liguori wrote:
> On 02/09/2010 04:45 PM, malc wrote:
> > On Tue, 9 Feb 2010, Anthony Liguori wrote:
> >
> >
> > > - fixed bug with size of registered ioport regions
> > >
> > > Signed-off-by: Anthony Liguori
> > > ---
> > > hw/ac97.c | 146
> > > +
On 02/09/2010 04:45 PM, malc wrote:
On Tue, 9 Feb 2010, Anthony Liguori wrote:
- fixed bug with size of registered ioport regions
Signed-off-by: Anthony Liguori
---
hw/ac97.c | 146 +
1 files changed, 60 insertions(+), 86 de
On Tue, 9 Feb 2010, Anthony Liguori wrote:
> - fixed bug with size of registered ioport regions
>
> Signed-off-by: Anthony Liguori
> ---
> hw/ac97.c | 146
> +
> 1 files changed, 60 insertions(+), 86 deletions(-)
>
> diff --git a/h
- fixed bug with size of registered ioport regions
Signed-off-by: Anthony Liguori
---
hw/ac97.c | 146 +
1 files changed, 60 insertions(+), 86 deletions(-)
diff --git a/hw/ac97.c b/hw/ac97.c
index 4319bc8..9fdf591 100644
--- a/hw/ac9
