Re: [Qemu-devel] [PATCH 07/11] i8259: Convert to MemoryRegion.

2011-08-28 Thread Avi Kivity
On 08/11/2011 01:28 AM, Richard Henderson wrote: The only non-obvious part is pic_poll_read which used "addr1>> 7" to detect whether one referred to either the master or slave PIC. Instead, test this directly. Crashes mipsel-test from qemu.org immediately: /* XXX: add generic master/slave

[Qemu-devel] [PATCH 07/11] i8259: Convert to MemoryRegion.

2011-08-10 Thread Richard Henderson
The only non-obvious part is pic_poll_read which used "addr1 >> 7" to detect whether one referred to either the master or slave PIC. Instead, test this directly. Signed-off-by: Richard Henderson --- hw/i8259.c | 65 ++- 1 files changed,