Re: [Qemu-devel] [PATCH 07/11] block: optimization blk_pwrite_compressed()

2016-06-28 Thread Kevin Wolf
Am 28.06.2016 um 14:32 hat Pavel Butsykin geschrieben: > On 28.06.2016 14:47, Kevin Wolf wrote: > >Am 31.05.2016 um 11:15 hat Denis V. Lunev geschrieben: > >>From: Pavel Butsykin > >> > >>For bdrv_pwrite_compressed() it looks like most of the code creating > >>coroutine > >>is duplicated in blk_p

Re: [Qemu-devel] [PATCH 07/11] block: optimization blk_pwrite_compressed()

2016-06-28 Thread Pavel Butsykin
On 28.06.2016 14:47, Kevin Wolf wrote: Am 31.05.2016 um 11:15 hat Denis V. Lunev geschrieben: From: Pavel Butsykin For bdrv_pwrite_compressed() it looks like most of the code creating coroutine is duplicated in blk_prw(). So we can just add a flag(BDRV_REQ_WRITE_COMPRESSED) and use the blk_prw

Re: [Qemu-devel] [PATCH 07/11] block: optimization blk_pwrite_compressed()

2016-06-28 Thread Kevin Wolf
Am 31.05.2016 um 11:15 hat Denis V. Lunev geschrieben: > From: Pavel Butsykin > > For bdrv_pwrite_compressed() it looks like most of the code creating coroutine > is duplicated in blk_prw(). So we can just add a > flag(BDRV_REQ_WRITE_COMPRESSED) > and use the blk_prw() as a generic one. > > Sig

Re: [Qemu-devel] [PATCH 07/11] block: optimization blk_pwrite_compressed()

2016-06-24 Thread Eric Blake
On 05/31/2016 03:15 AM, Denis V. Lunev wrote: > From: Pavel Butsykin > > For bdrv_pwrite_compressed() it looks like most of the code creating coroutine > is duplicated in blk_prw(). So we can just add a > flag(BDRV_REQ_WRITE_COMPRESSED) > and use the blk_prw() as a generic one. > > Signed-off-b

Re: [Qemu-devel] [PATCH 07/11] block: optimization blk_pwrite_compressed()

2016-06-15 Thread Stefan Hajnoczi
On Mon, Jun 13, 2016 at 02:16:08PM -0600, Eric Blake wrote: > On 06/13/2016 07:11 AM, Stefan Hajnoczi wrote: > > On Tue, May 31, 2016 at 12:15:26PM +0300, Denis V. Lunev wrote: > >> diff --git a/include/sysemu/block-backend.h > >> b/include/sysemu/block-backend.h > >> index 57df069..3d7b446 100644

Re: [Qemu-devel] [PATCH 07/11] block: optimization blk_pwrite_compressed()

2016-06-13 Thread Eric Blake
On 06/13/2016 07:11 AM, Stefan Hajnoczi wrote: > On Tue, May 31, 2016 at 12:15:26PM +0300, Denis V. Lunev wrote: >> diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h >> index 57df069..3d7b446 100644 >> --- a/include/sysemu/block-backend.h >> +++ b/include/sysemu/block-bac

Re: [Qemu-devel] [PATCH 07/11] block: optimization blk_pwrite_compressed()

2016-06-13 Thread Stefan Hajnoczi
On Tue, May 31, 2016 at 12:15:26PM +0300, Denis V. Lunev wrote: > diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h > index 57df069..3d7b446 100644 > --- a/include/sysemu/block-backend.h > +++ b/include/sysemu/block-backend.h > @@ -205,6 +205,9 @@ int coroutine_fn blk_co_

[Qemu-devel] [PATCH 07/11] block: optimization blk_pwrite_compressed()

2016-05-31 Thread Denis V. Lunev
From: Pavel Butsykin For bdrv_pwrite_compressed() it looks like most of the code creating coroutine is duplicated in blk_prw(). So we can just add a flag(BDRV_REQ_WRITE_COMPRESSED) and use the blk_prw() as a generic one. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Jeff Cody