Re: [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics counters

2019-02-04 Thread Markus Armbruster
Yuval Shaia writes: > On Mon, Feb 04, 2019 at 09:23:49AM +0100, Markus Armbruster wrote: >> Yuval Shaia writes: >> >> > On Fri, Feb 01, 2019 at 08:33:44AM +0100, Markus Armbruster wrote: >> >> Eric Blake writes: >> >> >> >> > On 1/31/19 2:08 PM, Yuval Shaia wrote: >> >> >> On Thu, Jan 31, 201

Re: [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics counters

2019-02-04 Thread Yuval Shaia
On Mon, Feb 04, 2019 at 09:23:49AM +0100, Markus Armbruster wrote: > Yuval Shaia writes: > > > On Fri, Feb 01, 2019 at 08:33:44AM +0100, Markus Armbruster wrote: > >> Eric Blake writes: > >> > >> > On 1/31/19 2:08 PM, Yuval Shaia wrote: > >> >> On Thu, Jan 31, 2019 at 07:17:16AM -0600, Eric Bla

Re: [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics counters

2019-02-04 Thread Markus Armbruster
Yuval Shaia writes: > On Fri, Feb 01, 2019 at 08:33:44AM +0100, Markus Armbruster wrote: >> Eric Blake writes: >> >> > On 1/31/19 2:08 PM, Yuval Shaia wrote: >> >> On Thu, Jan 31, 2019 at 07:17:16AM -0600, Eric Blake wrote: >> >>> On 1/31/19 7:08 AM, Yuval Shaia wrote: >> Signed-off-by: Yu

Re: [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics counters

2019-02-04 Thread Markus Armbruster
Yuval Shaia writes: > On Thu, Jan 31, 2019 at 07:17:16AM -0600, Eric Blake wrote: >> On 1/31/19 7:08 AM, Yuval Shaia wrote: >> > Signed-off-by: Yuval Shaia >> > --- >> > hmp-commands-info.hx | 14 ++ >> > monitor.c| 6 ++ >> > 2 files changed, 20 insertions(+) > > H

Re: [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics counters

2019-02-02 Thread Yuval Shaia
On Fri, Feb 01, 2019 at 11:42:57AM +, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: > > Eric Blake writes: > > > > > On 1/31/19 2:08 PM, Yuval Shaia wrote: > > >> On Thu, Jan 31, 2019 at 07:17:16AM -0600, Eric Blake wrote: > > >>> On 1/31/19 7:08 AM, Yuval Sha

Re: [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics counters

2019-02-02 Thread Yuval Shaia
On Fri, Feb 01, 2019 at 08:33:44AM +0100, Markus Armbruster wrote: > Eric Blake writes: > > > On 1/31/19 2:08 PM, Yuval Shaia wrote: > >> On Thu, Jan 31, 2019 at 07:17:16AM -0600, Eric Blake wrote: > >>> On 1/31/19 7:08 AM, Yuval Shaia wrote: > Signed-off-by: Yuval Shaia > --- >

Re: [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics counters

2019-02-01 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Eric Blake writes: > > > On 1/31/19 2:08 PM, Yuval Shaia wrote: > >> On Thu, Jan 31, 2019 at 07:17:16AM -0600, Eric Blake wrote: > >>> On 1/31/19 7:08 AM, Yuval Shaia wrote: > Signed-off-by: Yuval Shaia > --- > hmp-commands-info.hx

Re: [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics counters

2019-01-31 Thread Markus Armbruster
Eric Blake writes: > On 1/31/19 2:08 PM, Yuval Shaia wrote: >> On Thu, Jan 31, 2019 at 07:17:16AM -0600, Eric Blake wrote: >>> On 1/31/19 7:08 AM, Yuval Shaia wrote: Signed-off-by: Yuval Shaia --- hmp-commands-info.hx | 14 ++ monitor.c| 6 ++ >>>

Re: [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics counters

2019-01-31 Thread Eric Blake
On 1/31/19 2:08 PM, Yuval Shaia wrote: > On Thu, Jan 31, 2019 at 07:17:16AM -0600, Eric Blake wrote: >> On 1/31/19 7:08 AM, Yuval Shaia wrote: >>> Signed-off-by: Yuval Shaia >>> --- >>> hmp-commands-info.hx | 14 ++ >>> monitor.c| 6 ++ >>> 2 files changed, 20 inserti

Re: [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics counters

2019-01-31 Thread Yuval Shaia
On Thu, Jan 31, 2019 at 07:17:16AM -0600, Eric Blake wrote: > On 1/31/19 7:08 AM, Yuval Shaia wrote: > > Signed-off-by: Yuval Shaia > > --- > > hmp-commands-info.hx | 14 ++ > > monitor.c| 6 ++ > > 2 files changed, 20 insertions(+) Hi Eric, > > Commit message shou

Re: [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics counters

2019-01-31 Thread Eric Blake
On 1/31/19 7:08 AM, Yuval Shaia wrote: > Signed-off-by: Yuval Shaia > --- > hmp-commands-info.hx | 14 ++ > monitor.c| 6 ++ > 2 files changed, 20 insertions(+) Commit message should state WHY this is being added as an HMP-only command, and does not have a QMP counte

[Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics counters

2019-01-31 Thread Yuval Shaia
Signed-off-by: Yuval Shaia --- hmp-commands-info.hx | 14 ++ monitor.c| 6 ++ 2 files changed, 20 insertions(+) diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx index cbee8b944d..32f6215619 100644 --- a/hmp-commands-info.hx +++ b/hmp-commands-info.hx @@ -522,