Re: [Qemu-devel] [PATCH 06/18] target/mips: use lookup_and_goto_ptr on BS_STOP

2018-04-22 Thread Richard Henderson
On 04/20/2018 08:55 AM, Emilio G. Cota wrote: > The TB after BS_STOP is not fixed (e.g. helper_mtc0_hwrena > changes hflags, which ends up changing the TB flags via > cpu_get_tb_cpu_state). This requires a full lookup (i.e. > with flags) via lookup_and_goto_ptr instead of gen_goto_tb, > since the l

[Qemu-devel] [PATCH 06/18] target/mips: use lookup_and_goto_ptr on BS_STOP

2018-04-20 Thread Emilio G. Cota
The TB after BS_STOP is not fixed (e.g. helper_mtc0_hwrena changes hflags, which ends up changing the TB flags via cpu_get_tb_cpu_state). This requires a full lookup (i.e. with flags) via lookup_and_goto_ptr instead of gen_goto_tb, since the latter only looks at the PC for in-page goto's. Fix it.