Re: [Qemu-devel] [PATCH 06/18] armv7m: new NVIC utility functions

2015-12-02 Thread Peter Maydell
On 2 December 2015 at 23:18, Michael Davidsaver wrote: > On 11/20/2015 08:25 AM, Peter Maydell wrote: >> Hi; I have a lot of review comments on this patch set, but that's >> really because v7M exception logic is pretty complicated and >> our current code is a long way away from correct. You might

Re: [Qemu-devel] [PATCH 06/18] armv7m: new NVIC utility functions

2015-12-02 Thread Michael Davidsaver
On 11/20/2015 08:25 AM, Peter Maydell wrote: > On 9 November 2015 at 01:11, Michael Davidsaver wrote: >> Internal functions for operations previously done >> by GIC internals. >> >> nvic_irq_update() recalculates highest pending/active >> exceptions. >> >> armv7m_nvic_set_pending() include excepti

Re: [Qemu-devel] [PATCH 06/18] armv7m: new NVIC utility functions

2015-11-20 Thread Peter Maydell
On 9 November 2015 at 01:11, Michael Davidsaver wrote: > Internal functions for operations previously done > by GIC internals. > > nvic_irq_update() recalculates highest pending/active > exceptions. > > armv7m_nvic_set_pending() include exception escalation > logic. > > armv7m_nvic_acknowledge_irq

[Qemu-devel] [PATCH 06/18] armv7m: new NVIC utility functions

2015-11-08 Thread Michael Davidsaver
Internal functions for operations previously done by GIC internals. nvic_irq_update() recalculates highest pending/active exceptions. armv7m_nvic_set_pending() include exception escalation logic. armv7m_nvic_acknowledge_irq() and nvic_irq_update() update ARMCPU fields. Signed-off-by: Michael Da