Re: [Qemu-devel] [PATCH 06/13] 9p: darwin: Address minor differences

2018-05-31 Thread Greg Kurz
On Thu, 31 May 2018 15:23:45 -0400 Keno Fischer wrote: > Well, I do have the patch already to switch this and the other patterns, > so let me know if you want it or not ;). > Post it then and we'll see if people are happy with that :) > On Thu, May 31, 2018 at 3:22 PM, Greg Kurz wrote: > > On

Re: [Qemu-devel] [PATCH 06/13] 9p: darwin: Address minor differences

2018-05-31 Thread Greg Kurz
On Thu, 31 May 2018 12:27:35 -0400 Keno Fischer wrote: > >> --- a/hw/9pfs/9p-local.c > >> +++ b/hw/9pfs/9p-local.c > >> @@ -67,7 +67,10 @@ int local_open_nofollow(FsContext *fs_ctx, const char > >> *path, int flags, > >> assert(*path != '/'); > >> > >> head = g_strdup(path); >

Re: [Qemu-devel] [PATCH 06/13] 9p: darwin: Address minor differences

2018-05-31 Thread Keno Fischer
Well, I do have the patch already to switch this and the other patterns, so let me know if you want it or not ;). On Thu, May 31, 2018 at 3:22 PM, Greg Kurz wrote: > On Thu, 31 May 2018 12:27:35 -0400 > Keno Fischer wrote: > >> >> --- a/hw/9pfs/9p-local.c >> >> +++ b/hw/9pfs/9p-local.c >> >> @@

Re: [Qemu-devel] [PATCH 06/13] 9p: darwin: Address minor differences

2018-05-31 Thread Keno Fischer
>> --- a/hw/9pfs/9p-local.c >> +++ b/hw/9pfs/9p-local.c >> @@ -67,7 +67,10 @@ int local_open_nofollow(FsContext *fs_ctx, const char >> *path, int flags, >> assert(*path != '/'); >> >> head = g_strdup(path); >> -c = strchrnul(path, '/'); >> +/* equivalent to strchr

Re: [Qemu-devel] [PATCH 06/13] 9p: darwin: Address minor differences

2018-05-29 Thread Greg Kurz
On Sat, 26 May 2018 01:23:08 -0400 k...@juliacomputing.com wrote: > From: Keno Fischer > > - Darwin doesn't have strchrnul > - Comparisons of mode_t with -1 require an explicit cast, since mode_t > is unsigned on Darwin. > > Signed-off-by: Keno Fischer > --- > hw/9pfs/9p-local.c | 9 ++-

[Qemu-devel] [PATCH 06/13] 9p: darwin: Address minor differences

2018-05-25 Thread keno
From: Keno Fischer - Darwin doesn't have strchrnul - Comparisons of mode_t with -1 require an explicit cast, since mode_t is unsigned on Darwin. Signed-off-by: Keno Fischer --- hw/9pfs/9p-local.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/9pfs/9p-local.c