Re: [Qemu-devel] [PATCH 06/12] block/dirty-bitmap: add bdrv_dirty_bitmap_claim

2019-06-21 Thread John Snow
On 6/21/19 7:58 AM, Vladimir Sementsov-Ogievskiy wrote: > 20.06.2019 19:36, John Snow wrote: >> >> >> On 6/20/19 12:02 PM, Max Reitz wrote: >>> On 20.06.19 03:03, John Snow wrote: This function can claim an hbitmap to replace its own current hbitmap. In the case that the granularities

Re: [Qemu-devel] [PATCH 06/12] block/dirty-bitmap: add bdrv_dirty_bitmap_claim

2019-06-21 Thread Vladimir Sementsov-Ogievskiy
20.06.2019 19:36, John Snow wrote: > > > On 6/20/19 12:02 PM, Max Reitz wrote: >> On 20.06.19 03:03, John Snow wrote: >>> This function can claim an hbitmap to replace its own current hbitmap. >>> In the case that the granularities do not match, it will use >>> hbitmap_merge to copy the bit data

Re: [Qemu-devel] [PATCH 06/12] block/dirty-bitmap: add bdrv_dirty_bitmap_claim

2019-06-20 Thread John Snow
On 6/20/19 12:02 PM, Max Reitz wrote: > On 20.06.19 03:03, John Snow wrote: >> This function can claim an hbitmap to replace its own current hbitmap. >> In the case that the granularities do not match, it will use >> hbitmap_merge to copy the bit data instead. > > I really do not like this name

Re: [Qemu-devel] [PATCH 06/12] block/dirty-bitmap: add bdrv_dirty_bitmap_claim

2019-06-20 Thread Max Reitz
On 20.06.19 03:03, John Snow wrote: > This function can claim an hbitmap to replace its own current hbitmap. > In the case that the granularities do not match, it will use > hbitmap_merge to copy the bit data instead. I really do not like this name because to me it implies a relationship to bdrv_r

[Qemu-devel] [PATCH 06/12] block/dirty-bitmap: add bdrv_dirty_bitmap_claim

2019-06-19 Thread John Snow
This function can claim an hbitmap to replace its own current hbitmap. In the case that the granularities do not match, it will use hbitmap_merge to copy the bit data instead. Signed-off-by: John Snow --- include/block/block_int.h | 1 + include/qemu/hbitmap.h| 8 block/dirty-bitm