Re: [Qemu-devel] [PATCH 06/11] TCG/x86: use stack for TCG temps

2011-05-18 Thread Richard Henderson
On 05/17/2011 11:46 AM, Aurelien Jarno wrote: >> -tcg_set_frame(s, TCG_AREG0, offsetof(CPUState, temp_buf), >> - CPU_TEMP_BUF_NLONGS * sizeof(long)); >> } > > Note that this patch is likely to break calls to helpers which need > parameters on the stack, by judging at the curr

Re: [Qemu-devel] [PATCH 06/11] TCG/x86: use stack for TCG temps

2011-05-17 Thread Blue Swirl
On Tue, May 17, 2011 at 9:46 PM, Aurelien Jarno wrote: > On Sat, May 14, 2011 at 10:38:40PM +0300, Blue Swirl wrote: >> Use stack instead of temp_buf array in CPUState for TCG >> temps. >> >> Signed-off-by: Blue Swirl >> --- >>  tcg/i386/tcg-target.c |   19 ++- >>  1 files changed

Re: [Qemu-devel] [PATCH 06/11] TCG/x86: use stack for TCG temps

2011-05-17 Thread Aurelien Jarno
On Sat, May 14, 2011 at 10:38:40PM +0300, Blue Swirl wrote: > Use stack instead of temp_buf array in CPUState for TCG > temps. > > Signed-off-by: Blue Swirl > --- > tcg/i386/tcg-target.c | 19 ++- > 1 files changed, 10 insertions(+), 9 deletions(-) > > diff --git a/tcg/i386/tc

Re: [Qemu-devel] [PATCH 06/11] TCG/x86: use stack for TCG temps

2011-05-17 Thread Richard Henderson
On 05/14/2011 12:38 PM, Blue Swirl wrote: > -frame_size = push_size + TCG_STATIC_CALL_ARGS_SIZE; > +frame_size = push_size + TCG_STATIC_CALL_ARGS_SIZE + > +CPU_TEMP_BUF_NLONGS * sizeof(long); > frame_size = (frame_size + TCG_TARGET_STACK_ALIGN - 1) & > ~(TCG_TARGET_STA

[Qemu-devel] [PATCH 06/11] TCG/x86: use stack for TCG temps

2011-05-14 Thread Blue Swirl
Use stack instead of temp_buf array in CPUState for TCG temps. Signed-off-by: Blue Swirl --- tcg/i386/tcg-target.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index 01747f3..0e168ea 100644 --- a/tcg/i38