Re: [Qemu-devel] [PATCH 06/11] Goldfish: Added a nand controller.

2011-08-23 Thread Paolo Bonzini
On 08/22/2011 10:41 PM, Stefan Hajnoczi wrote: On Mon, Aug 22, 2011 at 3:16 PM, Paolo Bonzini wrote: On 08/22/2011 02:04 PM, Stefan Hajnoczi wrote: Please use the block layer instead of reinventing portable file I/O. Also, please check which of the utility functions already exist in QEMU. I

Re: [Qemu-devel] [PATCH 06/11] Goldfish: Added a nand controller.

2011-08-22 Thread Stefan Hajnoczi
On Mon, Aug 22, 2011 at 3:16 PM, Paolo Bonzini wrote: > On 08/22/2011 02:04 PM, Stefan Hajnoczi wrote: >> >> Please use the block layer instead of reinventing portable file I/O. >> >> Also, please check which of the utility functions already exist in >> QEMU.  If a utility function in this patch i

Re: [Qemu-devel] [PATCH 06/11] Goldfish: Added a nand controller.

2011-08-22 Thread Paolo Bonzini
On 08/22/2011 02:04 PM, Stefan Hajnoczi wrote: Please use the block layer instead of reinventing portable file I/O. Also, please check which of the utility functions already exist in QEMU. If a utility function in this patch is needed it should be made generic for all of QEMU, not just goldfish

Re: [Qemu-devel] [PATCH 06/11] Goldfish: Added a nand controller.

2011-08-22 Thread Stefan Hajnoczi
On Mon, Aug 22, 2011 at 10:39 AM, Patrick Jackson wrote: > > The paths to the system images must be specified from the command line as > follows. > -global goldfish_nand.system_init_path=/path/to/initial/system/image -global > goldfish_nand.user_data_path=/path/to/user/data > Signed-off-by: Patric