Re: [Qemu-devel] [PATCH 06/10] qapi: simplify qmp_input_next_list

2012-03-22 Thread Anthony Liguori
On 03/22/2012 04:24 PM, Paolo Bonzini wrote: Il 22/03/2012 21:22, Anthony Liguori ha scritto: Signed-off-by: Paolo Bonzini I've been staring a this patch for the past 5 minutes and I can't figure out what's going on here. Maybe the code was too obscure to begin with. Could you enhance the c

Re: [Qemu-devel] [PATCH 06/10] qapi: simplify qmp_input_next_list

2012-03-22 Thread Paolo Bonzini
Il 22/03/2012 21:22, Anthony Liguori ha scritto: >> >> Signed-off-by: Paolo Bonzini > > I've been staring a this patch for the past 5 minutes and I can't figure > out what's going on here. > > Maybe the code was too obscure to begin with. Could you enhance the > commit message a bit with what's

Re: [Qemu-devel] [PATCH 06/10] qapi: simplify qmp_input_next_list

2012-03-22 Thread Anthony Liguori
On 03/22/2012 06:51 AM, Paolo Bonzini wrote: Tweak a bit the code so that there is cleaner separation between operation on the list and operation on the output. The next patch requires this change. Signed-off-by: Paolo Bonzini I've been staring a this patch for the past 5 minutes and I can't

[Qemu-devel] [PATCH 06/10] qapi: simplify qmp_input_next_list

2012-03-22 Thread Paolo Bonzini
Tweak a bit the code so that there is cleaner separation between operation on the list and operation on the output. The next patch requires this change. Signed-off-by: Paolo Bonzini --- qapi/qmp-input-visitor.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git