Re: [Qemu-devel] [PATCH 06/10] migration: Make sure that we pass the right cache size

2017-10-18 Thread Juan Quintela
Peter Xu wrote: > On Tue, Oct 10, 2017 at 08:15:38PM +0200, Juan Quintela wrote: >> Instead of passing silently round down the number of pages, make it an >> error that the cache size is not a multiple of 2. > > s/multiple/power/? Thanks. > Would this patch break existing users? I have a proble

Re: [Qemu-devel] [PATCH 06/10] migration: Make sure that we pass the right cache size

2017-10-11 Thread Peter Xu
On Tue, Oct 10, 2017 at 08:15:38PM +0200, Juan Quintela wrote: > Instead of passing silently round down the number of pages, make it an > error that the cache size is not a multiple of 2. s/multiple/power/? Would this patch break existing users? > > Signed-off-by: Juan Quintela > --- > migrat

[Qemu-devel] [PATCH 06/10] migration: Make sure that we pass the right cache size

2017-10-10 Thread Juan Quintela
Instead of passing silently round down the number of pages, make it an error that the cache size is not a multiple of 2. Signed-off-by: Juan Quintela --- migration/page_cache.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/migration/page_cache.c b/migration/pag