Re: [Qemu-devel] [PATCH 05/99] s390-ccw: force diag 308 subcode to unsigned long

2018-07-24 Thread Michael Roth
Quoting Cornelia Huck (2018-07-24 06:07:43) > On Tue, 24 Jul 2018 11:40:04 +0200 > Cornelia Huck wrote: > > > On Mon, 23 Jul 2018 17:14:54 -0500 > > Michael Roth wrote: > > > > > Quoting Michael Roth (2018-07-23 15:16:14) > > > > From: Cornelia Huck > > > > > > > > We currently pass an inte

Re: [Qemu-devel] [PATCH 05/99] s390-ccw: force diag 308 subcode to unsigned long

2018-07-24 Thread Cornelia Huck
On Tue, 24 Jul 2018 11:40:04 +0200 Cornelia Huck wrote: > On Mon, 23 Jul 2018 17:14:54 -0500 > Michael Roth wrote: > > > Quoting Michael Roth (2018-07-23 15:16:14) > > > From: Cornelia Huck > > > > > > We currently pass an integer as the subcode parameter. However, > > > the upper bits of t

Re: [Qemu-devel] [PATCH 05/99] s390-ccw: force diag 308 subcode to unsigned long

2018-07-24 Thread Cornelia Huck
On Mon, 23 Jul 2018 17:14:54 -0500 Michael Roth wrote: > Quoting Michael Roth (2018-07-23 15:16:14) > > From: Cornelia Huck > > > > We currently pass an integer as the subcode parameter. However, > > the upper bits of the register containing the subcode need to > > be 0, which is not guaranteed

Re: [Qemu-devel] [PATCH 05/99] s390-ccw: force diag 308 subcode to unsigned long

2018-07-23 Thread Michael Roth
Quoting Michael Roth (2018-07-23 15:16:14) > From: Cornelia Huck > > We currently pass an integer as the subcode parameter. However, > the upper bits of the register containing the subcode need to > be 0, which is not guaranteed unless we explicitly specify the > subcode to be an unsigned long va

[Qemu-devel] [PATCH 05/99] s390-ccw: force diag 308 subcode to unsigned long

2018-07-23 Thread Michael Roth
From: Cornelia Huck We currently pass an integer as the subcode parameter. However, the upper bits of the register containing the subcode need to be 0, which is not guaranteed unless we explicitly specify the subcode to be an unsigned long value. Fixes: d046c51dad3 ("pc-bios/s390-ccw: Get device