Re: [Qemu-devel] [PATCH 05/34] block: Use macro for cache option names

2015-05-11 Thread Max Reitz
On 08.05.2015 19:21, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- blockdev.c| 24 include/block/block.h | 8 2 files changed, 20 insertions(+), 12 deletions(-) Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH 05/34] block: Use macro for cache option names

2015-05-11 Thread Max Reitz
On 11.05.2015 16:51, Kevin Wolf wrote: Am 11.05.2015 um 16:40 hat Max Reitz geschrieben: On 08.05.2015 19:21, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- blockdev.c| 24 include/block/block.h | 8 2 files changed, 20 insertions(+), 12 dele

Re: [Qemu-devel] [PATCH 05/34] block: Use macro for cache option names

2015-05-11 Thread Kevin Wolf
Am 11.05.2015 um 16:40 hat Max Reitz geschrieben: > On 08.05.2015 19:21, Kevin Wolf wrote: > >Signed-off-by: Kevin Wolf > >--- > > blockdev.c| 24 > > include/block/block.h | 8 > > 2 files changed, 20 insertions(+), 12 deletions(-) > > Any reason f

Re: [Qemu-devel] [PATCH 05/34] block: Use macro for cache option names

2015-05-11 Thread Max Reitz
On 08.05.2015 19:21, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- blockdev.c| 24 include/block/block.h | 8 2 files changed, 20 insertions(+), 12 deletions(-) Any reason for not making it part of the BLOCK_OPT_* macros in block_int.h? Max

Re: [Qemu-devel] [PATCH 05/34] block: Use macro for cache option names

2015-05-08 Thread Eric Blake
On 05/08/2015 11:21 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > blockdev.c| 24 > include/block/block.h | 8 > 2 files changed, 20 insertions(+), 12 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919

[Qemu-devel] [PATCH 05/34] block: Use macro for cache option names

2015-05-08 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- blockdev.c| 24 include/block/block.h | 8 2 files changed, 20 insertions(+), 12 deletions(-) diff --git a/blockdev.c b/blockdev.c index 5eaf77e..77cbe72 100644 --- a/blockdev.c +++ b/blockdev.c @@ -391,13 +391,13 @@ st