Re: [Qemu-devel] [PATCH 05/18] migration: avoid using error_is_set

2012-10-04 Thread Paolo Bonzini
Il 04/10/2012 20:06, Luiz Capitulino ha scritto: >> > +if (ret < 0 || local_err) { >> > +if (!local_err) { >> > +error_set_errno(errp, -ret, QERR_UNDEFINED_ERROR); > Two problems here. First, ret usually is not -errno. If we really want to > use it here (I think this is grea

Re: [Qemu-devel] [PATCH 05/18] migration: avoid using error_is_set

2012-10-04 Thread Luiz Capitulino
On Wed, 3 Oct 2012 16:36:52 +0200 Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini The patch's description is a bit misleading. The real problem this fixes is that the migration code is using errp to detect "internal" errors, this means that it relies on errp being non-NULL. There's no pro

[Qemu-devel] [PATCH 05/18] migration: avoid using error_is_set

2012-10-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- migration-tcp.c | 8 +--- migration.c | 13 +++-- 2 file modificati, 12 inserzioni(+), 9 rimozioni(-) diff --git a/migration-tcp.c b/migration-tcp.c index a15c2b8..78337a3 100644 --- a/migration-tcp.c +++ b/migration-tcp.c @@ -71,14 +71,16 @@ sta