Re: [Qemu-devel] [PATCH 05/17] timer: generalize Dallas/Maxim RTC i2c devices

2017-12-27 Thread Michael Davidsaver
On 12/06/2017 05:14 AM, David Gibson wrote: > On Sun, Dec 03, 2017 at 03:15:10PM -0600, Michael Davidsaver wrote: >> On 11/29/2017 11:13 PM, David Gibson wrote: >>> On Sun, Nov 26, 2017 at 03:59:03PM -0600, Michael Davidsaver wrote: Support for: ds1307, ds1337, ds1338, ds1339, ds1340, ds1

Re: [Qemu-devel] [PATCH 05/17] timer: generalize Dallas/Maxim RTC i2c devices

2017-12-06 Thread David Gibson
On Sun, Dec 03, 2017 at 03:15:10PM -0600, Michael Davidsaver wrote: > On 11/29/2017 11:13 PM, David Gibson wrote: > > On Sun, Nov 26, 2017 at 03:59:03PM -0600, Michael Davidsaver wrote: > >> Support for: ds1307, ds1337, ds1338, ds1339, > >> ds1340, ds1375, ds1388, and ds3231. > >> > >> Tested with

Re: [Qemu-devel] [PATCH 05/17] timer: generalize Dallas/Maxim RTC i2c devices

2017-12-03 Thread Michael Davidsaver
On 11/29/2017 11:13 PM, David Gibson wrote: > On Sun, Nov 26, 2017 at 03:59:03PM -0600, Michael Davidsaver wrote: >> Support for: ds1307, ds1337, ds1338, ds1339, >> ds1340, ds1375, ds1388, and ds3231. >> >> Tested with ds1338 and ds1375. >> >> Signed-off-by: Michael Davidsaver > > I certainly lik

Re: [Qemu-devel] [PATCH 05/17] timer: generalize Dallas/Maxim RTC i2c devices

2017-11-30 Thread David Gibson
On Sun, Nov 26, 2017 at 03:59:03PM -0600, Michael Davidsaver wrote: > Support for: ds1307, ds1337, ds1338, ds1339, > ds1340, ds1375, ds1388, and ds3231. > > Tested with ds1338 and ds1375. > > Signed-off-by: Michael Davidsaver I certainly like the idea of consolidating this code, but reviewing t

[Qemu-devel] [PATCH 05/17] timer: generalize Dallas/Maxim RTC i2c devices

2017-11-26 Thread Michael Davidsaver
Support for: ds1307, ds1337, ds1338, ds1339, ds1340, ds1375, ds1388, and ds3231. Tested with ds1338 and ds1375. Signed-off-by: Michael Davidsaver --- default-configs/arm-softmmu.mak | 2 +- hw/timer/Makefile.objs | 2 +- hw/timer/ds-rtc-i2c.c | 461 +++