Re: [Qemu-devel] [PATCH 05/17] tcg: Simplify how dump_drift_info() prints

2019-04-12 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > dump_drift_info() takes an fprintf()-like callback and a FILE * to pass > to it. Me thinks there's a pattern here > Its only caller hmp_info_jit() passes monitor_fprintf() and a Monitor > * cast to FILE *. monitor_fprintf() casts it right back

[Qemu-devel] [PATCH 05/17] tcg: Simplify how dump_drift_info() prints

2019-04-11 Thread Markus Armbruster
dump_drift_info() takes an fprintf()-like callback and a FILE * to pass to it. Its only caller hmp_info_jit() passes monitor_fprintf() and a Monitor * cast to FILE *. monitor_fprintf() casts it right back, and is otherwise identical to monitor_printf(). The type-punning is ugly. Drop the callba