Re: [Qemu-devel] [PATCH 05/16] mirror: use bottom half to re-enter coroutine

2016-03-08 Thread Paolo Bonzini
On 09/03/2016 04:19, Fam Zheng wrote: >> > +/* The I/O operation is not finished until the callback returns. >> > + * If we call qemu_coroutine_enter here, there is the possibility >> > + * of a deadlock when the coroutine calls bdrv_drained_begin. >> > + */ >> > +op->co_enter

Re: [Qemu-devel] [PATCH 05/16] mirror: use bottom half to re-enter coroutine

2016-03-08 Thread Fam Zheng
On Tue, 02/16 18:56, Paolo Bonzini wrote: > mirror is calling bdrv_drain from an AIO callback---more precisely, > the bdrv_drain happens far away from the AIO callback, in the coroutine that > the AIO callback enters. > > This used to be okay because bdrv_drain more or less tried to guess > when a

[Qemu-devel] [PATCH 05/16] mirror: use bottom half to re-enter coroutine

2016-02-16 Thread Paolo Bonzini
mirror is calling bdrv_drain from an AIO callback---more precisely, the bdrv_drain happens far away from the AIO callback, in the coroutine that the AIO callback enters. This used to be okay because bdrv_drain more or less tried to guess when all AIO callbacks were done; however it will cause a de