Re: [Qemu-devel] [PATCH 05/14] timer: ds1338 change write handling and fix wday_offset handling

2018-07-15 Thread David Gibson
On Thu, Jul 05, 2018 at 11:19:52AM -0700, Michael Davidsaver wrote: > instead of a read-modify-write, do direct translation > of device registers to struct tm members. > > This new ds1338_update() is the reverse of > the existing capture_current_time(). > > Simplifies later handling of CENTURY bi

[Qemu-devel] [PATCH 05/14] timer: ds1338 change write handling and fix wday_offset handling

2018-07-05 Thread Michael Davidsaver
instead of a read-modify-write, do direct translation of device registers to struct tm members. This new ds1338_update() is the reverse of the existing capture_current_time(). Simplifies later handling of CENTURY bit in similar Dallas RTC chips. Correctly handle different real weekday in guest a

Re: [Qemu-devel] [PATCH 05/14] timer: ds1338 change write handling

2018-04-13 Thread Peter Maydell
On 24 March 2018 at 19:24, Michael Davidsaver wrote: > instead of a read-modify-write, do direct translation > of device registers to struct tm members. > > This new ds1338_update() is the reverse of > the existing capture_current_time(). > > Simplifies later handling of CENTURY bit in > similar D

[Qemu-devel] [PATCH 05/14] timer: ds1338 change write handling

2018-03-24 Thread Michael Davidsaver
instead of a read-modify-write, do direct translation of device registers to struct tm members. This new ds1338_update() is the reverse of the existing capture_current_time(). Simplifies later handling of CENTURY bit in similar Dallas RTC chips. Signed-off-by: Michael Davidsaver --- hw/timer/d