Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-05 Thread Stefan Weil
On Wed, Nov 02, 2011 at 09:16:34AM +0200, Michael S. Tsirkin wrote: On Mon, Oct 31, 2011 at 05:06:49PM +1100, David Gibson wrote: From: Eduard - Gabriel Munteanu [snip] @@ -744,21 +713,26 @@ static void dump_statistics(EEPRO100State * s) * values which really matter. * Number of data should c

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-03 Thread David Gibson
On Thu, Nov 03, 2011 at 02:25:45PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 03, 2011 at 04:16:34PM +1100, David Gibson wrote: > > On Wed, Nov 02, 2011 at 09:16:34AM +0200, Michael S. Tsirkin wrote: > > > On Mon, Oct 31, 2011 at 05:06:49PM +1100, David Gibson wrote: > > > > From: Eduard - Gabr

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-03 Thread Michael S. Tsirkin
On Thu, Nov 03, 2011 at 04:16:34PM +1100, David Gibson wrote: > On Wed, Nov 02, 2011 at 09:16:34AM +0200, Michael S. Tsirkin wrote: > > On Mon, Oct 31, 2011 at 05:06:49PM +1100, David Gibson wrote: > > > From: Eduard - Gabriel Munteanu > [snip] > > > @@ -744,21 +713,26 @@ static void dump_statisti

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-02 Thread David Gibson
On Wed, Nov 02, 2011 at 09:16:34AM +0200, Michael S. Tsirkin wrote: > On Mon, Oct 31, 2011 at 05:06:49PM +1100, David Gibson wrote: > > From: Eduard - Gabriel Munteanu [snip] > > @@ -744,21 +713,26 @@ static void dump_statistics(EEPRO100State * s) > > * values which really matter. > >

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-02 Thread David Gibson
On Wed, Nov 02, 2011 at 09:11:57PM +0200, Michael S. Tsirkin wrote: > On Wed, Nov 02, 2011 at 06:56:55PM +0100, Alexander Graf wrote: > > It gets us that downstreams can convert to the API for 1.0. It just > > feels a lot more right to change APIs for a 1.0 release than a 1.1 release. > > Anyway,

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-02 Thread Michael S. Tsirkin
On Wed, Nov 02, 2011 at 06:56:55PM +0100, Alexander Graf wrote: > It gets us that downstreams can convert to the API for 1.0. It just > feels a lot more right to change APIs for a 1.0 release than a 1.1 release. Anyway, I hope at least what looks like the alignment bug in eepro100 introduced by th

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-02 Thread Alexander Graf
Anthony Liguori wrote: > On 11/02/2011 12:56 PM, Alexander Graf wrote: >> Michael S. Tsirkin wrote: >>> On Tue, Nov 01, 2011 at 03:24:28PM -0500, Anthony Liguori wrote: >>> >>> What does it get us, applying it before freeze? >>> It's an api change without new functionality. >>> Seems better on -nex

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-02 Thread Anthony Liguori
On 11/02/2011 12:56 PM, Alexander Graf wrote: Michael S. Tsirkin wrote: On Tue, Nov 01, 2011 at 03:24:28PM -0500, Anthony Liguori wrote: What does it get us, applying it before freeze? It's an api change without new functionality. Seems better on -next branch. It gets us that downstreams can

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-02 Thread Alexander Graf
Michael S. Tsirkin wrote: > On Tue, Nov 01, 2011 at 03:24:28PM -0500, Anthony Liguori wrote: > >> On 10/31/2011 11:45 AM, Stefan Weil wrote: >> >>> Am 31.10.2011 07:06, schrieb David Gibson: >>> From: Eduard - Gabriel Munteanu This updates the eepro100 device emulation

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-02 Thread Anthony Liguori
On 11/02/2011 02:40 AM, Michael S. Tsirkin wrote: On Tue, Nov 01, 2011 at 03:24:28PM -0500, Anthony Liguori wrote: On 10/31/2011 11:45 AM, Stefan Weil wrote: Am 31.10.2011 07:06, schrieb David Gibson: From: Eduard - Gabriel Munteanu This updates the eepro100 device emulation to use the explic

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-02 Thread Michael S. Tsirkin
On Tue, Nov 01, 2011 at 03:24:28PM -0500, Anthony Liguori wrote: > >Hi, > > > >the patch looks reasonable. I only suggest a formal change: > > > >There are lots of unnecessary type casts in several of your patches. > >I marked them here, but they should be removed anywhere. > > Agreed. However, I

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-02 Thread Michael S. Tsirkin
On Tue, Nov 01, 2011 at 03:24:28PM -0500, Anthony Liguori wrote: > On 10/31/2011 11:45 AM, Stefan Weil wrote: > >Am 31.10.2011 07:06, schrieb David Gibson: > >>From: Eduard - Gabriel Munteanu > >> > >>This updates the eepro100 device emulation to use the explicit PCI DMA > >>functions, instead of d

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-02 Thread Michael S. Tsirkin
On Mon, Oct 31, 2011 at 05:06:49PM +1100, David Gibson wrote: > From: Eduard - Gabriel Munteanu > > This updates the eepro100 device emulation to use the explicit PCI DMA > functions, instead of directly calling physical memory access functions. > > Signed-off-by: Eduard - Gabriel Munteanu > Si

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-01 Thread Anthony Liguori
On 10/31/2011 11:45 AM, Stefan Weil wrote: Am 31.10.2011 07:06, schrieb David Gibson: From: Eduard - Gabriel Munteanu This updates the eepro100 device emulation to use the explicit PCI DMA functions, instead of directly calling physical memory access functions. Signed-off-by: Eduard - Gabriel

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-10-31 Thread Stefan Weil
Am 31.10.2011 07:06, schrieb David Gibson: From: Eduard - Gabriel Munteanu This updates the eepro100 device emulation to use the explicit PCI DMA functions, instead of directly calling physical memory access functions. Signed-off-by: Eduard - Gabriel Munteanu Signed-off-by: David Gibson Signed-

[Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-10-31 Thread David Gibson
From: Eduard - Gabriel Munteanu This updates the eepro100 device emulation to use the explicit PCI DMA functions, instead of directly calling physical memory access functions. Signed-off-by: Eduard - Gabriel Munteanu Signed-off-by: David Gibson Signed-off-by: Alexey Kardashevskiy --- hw/eepr