Re: [Qemu-devel] [PATCH 05/13] target-ppc: implement stxvl instruction

2016-12-05 Thread Nikunj A Dadhania
Richard Henderson writes: > On 12/05/2016 03:25 AM, Nikunj A Dadhania wrote: >> +for (i = 15; i > 15 - end; i--) { >> +cpu_stb_data_ra(env, addr, xt.u8[i], GETPC()); >> +addr = addr_add(env, addr, 1); >> +} > > (1) you need to handle nb > 16. Sure will handle that. > (2)

Re: [Qemu-devel] [PATCH 05/13] target-ppc: implement stxvl instruction

2016-12-05 Thread Richard Henderson
On 12/05/2016 03:25 AM, Nikunj A Dadhania wrote: > +for (i = 15; i > 15 - end; i--) { > +cpu_stb_data_ra(env, addr, xt.u8[i], GETPC()); > +addr = addr_add(env, addr, 1); > +} (1) you need to handle nb > 16. (2) don't you need different byte indexing for little-endian? r~

[Qemu-devel] [PATCH 05/13] target-ppc: implement stxvl instruction

2016-12-05 Thread Nikunj A Dadhania
stxvl: Store VSX Vector with Length Vector (8-bit elements) in BE: +---+---+---+---+---+---+---+---+---+---+---+---+---+---+--+--+ |“T”|“h”|“i”|“s”|“ ”|“i”|“s”|“ ”|“a”|“ ”|“T”|“E”|“S”|“T”|00|00| +---+---+---+---+---+---+---+---+---+---+---+---+---+---+--+--+ Vector (8-bit elements) in LE: +--+--+