Re: [Qemu-devel] [PATCH 05/13] target/arm: Add some comments in Thumb decode

2018-10-03 Thread Richard Henderson
On 10/2/18 11:35 AM, Peter Maydell wrote: > Add some comments to the Thumb decoder indicating what bits > of the instruction have been decoded at various points in > the code. > > This is not an exhaustive set of comments; we're gradually > adding comments as we work with particular bits of the co

Re: [Qemu-devel] [PATCH 05/13] target/arm: Add some comments in Thumb decode

2018-10-03 Thread Philippe Mathieu-Daudé
On 02/10/2018 18:35, Peter Maydell wrote: > Add some comments to the Thumb decoder indicating what bits > of the instruction have been decoded at various points in > the code. > > This is not an exhaustive set of comments; we're gradually > adding comments as we work with particular bits of the co

[Qemu-devel] [PATCH 05/13] target/arm: Add some comments in Thumb decode

2018-10-02 Thread Peter Maydell
Add some comments to the Thumb decoder indicating what bits of the instruction have been decoded at various points in the code. This is not an exhaustive set of comments; we're gradually adding comments as we work with particular bits of the code. Signed-off-by: Peter Maydell --- Specifically, I