Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 07:50:07PM +0300, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 06:30:59PM +0200, Jan Kiszka wrote: > > Caching the host bridge generically means changing all chipsets and, > > well, also testing that they still work afterward. As explained before, > > I'd really like

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 06:30:59PM +0200, Jan Kiszka wrote: > Caching the host bridge generically means changing all chipsets and, > well, also testing that they still work afterward. As explained before, > I'd really like to avoid doing this in a single step. Surely it is not hard to find a way t

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Jan Kiszka
On 2012-06-10 17:55, Michael S. Tsirkin wrote: >>> So if you expect me to merge this work, then either Jan does (1), or >>> gives up and does (2), or I find some time and do (1), or I fail to do >>> (1) and get convinced that we need to do (3). Or someone else gets >>> involved. >> >> I still have

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 09:25:06AM -0600, Alex Williamson wrote: > On Sun, 2012-06-10 at 17:43 +0300, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 08:19:28AM -0600, Alex Williamson wrote: > > > On Sun, 2012-06-10 at 12:49 +0200, Jan Kiszka wrote: > > > > On 2012-06-10 12:41, Michael S. Tsi

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Alex Williamson
On Sun, 2012-06-10 at 17:43 +0300, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 08:19:28AM -0600, Alex Williamson wrote: > > On Sun, 2012-06-10 at 12:49 +0200, Jan Kiszka wrote: > > > On 2012-06-10 12:41, Michael S. Tsirkin wrote: > > > > On Sun, Jun 10, 2012 at 12:08:23PM +0200, Jan Kiszka

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 08:19:28AM -0600, Alex Williamson wrote: > On Sun, 2012-06-10 at 12:49 +0200, Jan Kiszka wrote: > > On 2012-06-10 12:41, Michael S. Tsirkin wrote: > > > On Sun, Jun 10, 2012 at 12:08:23PM +0200, Jan Kiszka wrote: > > >> On 2012-06-10 11:55, Michael S. Tsirkin wrote: > > >>>

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Alex Williamson
On Sun, 2012-06-10 at 12:49 +0200, Jan Kiszka wrote: > On 2012-06-10 12:41, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 12:08:23PM +0200, Jan Kiszka wrote: > >> On 2012-06-10 11:55, Michael S. Tsirkin wrote: > >>> On Thu, Jun 07, 2012 at 06:46:38PM +0200, Jan Kiszka wrote: > On 2012-

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 12:49:11PM +0200, Jan Kiszka wrote: > On 2012-06-10 12:41, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 12:08:23PM +0200, Jan Kiszka wrote: > >> On 2012-06-10 11:55, Michael S. Tsirkin wrote: > >>> On Thu, Jun 07, 2012 at 06:46:38PM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Jan Kiszka
On 2012-06-10 12:41, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 12:08:23PM +0200, Jan Kiszka wrote: >> On 2012-06-10 11:55, Michael S. Tsirkin wrote: >>> On Thu, Jun 07, 2012 at 06:46:38PM +0200, Jan Kiszka wrote: On 2012-06-07 18:28, Michael S. Tsirkin wrote: > On Thu, Jun 07, 20

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 12:08:23PM +0200, Jan Kiszka wrote: > On 2012-06-10 11:55, Michael S. Tsirkin wrote: > > On Thu, Jun 07, 2012 at 06:46:38PM +0200, Jan Kiszka wrote: > >> On 2012-06-07 18:28, Michael S. Tsirkin wrote: > >>> On Thu, Jun 07, 2012 at 05:10:17PM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Jan Kiszka
On 2012-06-10 11:55, Michael S. Tsirkin wrote: > On Thu, Jun 07, 2012 at 06:46:38PM +0200, Jan Kiszka wrote: >> On 2012-06-07 18:28, Michael S. Tsirkin wrote: >>> On Thu, Jun 07, 2012 at 05:10:17PM +0200, Jan Kiszka wrote: On 2012-06-07 16:32, Michael S. Tsirkin wrote: > On Mon, Jun 04, 20

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-10 Thread Michael S. Tsirkin
On Thu, Jun 07, 2012 at 06:46:38PM +0200, Jan Kiszka wrote: > On 2012-06-07 18:28, Michael S. Tsirkin wrote: > > On Thu, Jun 07, 2012 at 05:10:17PM +0200, Jan Kiszka wrote: > >> On 2012-06-07 16:32, Michael S. Tsirkin wrote: > >>> On Mon, Jun 04, 2012 at 10:52:13AM +0200, Jan Kiszka wrote: > @

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-07 Thread Michael S. Tsirkin
On Thu, Jun 07, 2012 at 06:46:38PM +0200, Jan Kiszka wrote: > On 2012-06-07 18:28, Michael S. Tsirkin wrote: > > On Thu, Jun 07, 2012 at 05:10:17PM +0200, Jan Kiszka wrote: > >> On 2012-06-07 16:32, Michael S. Tsirkin wrote: > >>> On Mon, Jun 04, 2012 at 10:52:13AM +0200, Jan Kiszka wrote: > @

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-07 Thread Jan Kiszka
On 2012-06-07 18:28, Michael S. Tsirkin wrote: > On Thu, Jun 07, 2012 at 05:10:17PM +0200, Jan Kiszka wrote: >> On 2012-06-07 16:32, Michael S. Tsirkin wrote: >>> On Mon, Jun 04, 2012 at 10:52:13AM +0200, Jan Kiszka wrote: @@ -1089,6 +1093,14 @@ static void pci_set_irq(void *opaque, int irq_nu

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-07 Thread Michael S. Tsirkin
On Thu, Jun 07, 2012 at 05:10:17PM +0200, Jan Kiszka wrote: > On 2012-06-07 16:32, Michael S. Tsirkin wrote: > > On Mon, Jun 04, 2012 at 10:52:13AM +0200, Jan Kiszka wrote: > >> @@ -1089,6 +1093,14 @@ static void pci_set_irq(void *opaque, int irq_num, > >> int level) > >> pci_change_irq_level

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-07 Thread Jan Kiszka
On 2012-06-07 16:32, Michael S. Tsirkin wrote: > On Mon, Jun 04, 2012 at 10:52:13AM +0200, Jan Kiszka wrote: >> @@ -1089,6 +1093,14 @@ static void pci_set_irq(void *opaque, int irq_num, >> int level) >> pci_change_irq_level(pci_dev, irq_num, change); >> } >> >> +PCIINTxRoute pci_device_rou

Re: [Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-07 Thread Michael S. Tsirkin
On Mon, Jun 04, 2012 at 10:52:13AM +0200, Jan Kiszka wrote: > @@ -1089,6 +1093,14 @@ static void pci_set_irq(void *opaque, int irq_num, int > level) > pci_change_irq_level(pci_dev, irq_num, change); > } > > +PCIINTxRoute pci_device_route_intx_to_irq(PCIDevice *dev, int pin) > +{ > +PCI

[Qemu-devel] [PATCH 05/13] pci: Add pci_device_route_intx_to_irq

2012-06-04 Thread Jan Kiszka
Add a PCI IRQ path discovery function that walks from a given device to the host bridge, returning the mode (enabled/inverted/disabled) and the IRQ number that is reported to the attached interrupt controller. For this purpose, another host bridge callback function is introduced: route_intx_to_irq.