Re: [Qemu-devel] [PATCH 05/12] monitor: register the qapi generated commands

2016-06-24 Thread Marc-André Lureau
On Fri, Jun 24, 2016 at 6:31 AM, Eric Blake wrote: >> +qcmd = qmp_find_command(cmd_name); > > Is it worth creating a single type that contains both mon_cmd_t and > QmpCommand information, so that we don't need two similarly-named > functions to look up two related pieces of information? Not n

Re: [Qemu-devel] [PATCH 05/12] monitor: register the qapi generated commands

2016-06-23 Thread Eric Blake
On 06/22/2016 06:08 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Stop using the so-called 'middle' mode. Instead, use qmp_find_command() > from generated qapi commands registry. > > Note: this commit requires a 'make clean' prior to make, since the > generated files do no

Re: [Qemu-devel] [PATCH 05/12] monitor: register the qapi generated commands

2016-06-23 Thread Marc-André Lureau
Hi - Original Message - > > > On 23/06/2016 02:08, marcandre.lur...@redhat.com wrote: > > > > Stop using the so-called 'middle' mode. Instead, use qmp_find_command() > > from generated qapi commands registry. > > > > Note: this commit requires a 'make clean' prior to make, since the >

Re: [Qemu-devel] [PATCH 05/12] monitor: register the qapi generated commands

2016-06-22 Thread Paolo Bonzini
On 23/06/2016 02:08, marcandre.lur...@redhat.com wrote: > > Stop using the so-called 'middle' mode. Instead, use qmp_find_command() > from generated qapi commands registry. > > Note: this commit requires a 'make clean' prior to make, since the > generated files do not depend on Makefile (due to

[Qemu-devel] [PATCH 05/12] monitor: register the qapi generated commands

2016-06-22 Thread marcandre . lureau
From: Marc-André Lureau Stop using the so-called 'middle' mode. Instead, use qmp_find_command() from generated qapi commands registry. Note: this commit requires a 'make clean' prior to make, since the generated files do not depend on Makefile (due to a cyclic rule introduced in 4115852bb0). Si