Re: [Qemu-devel] [PATCH 05/11] qemu.py: Use custom exceptions rather than Exception

2017-07-24 Thread Lukáš Doktor
Dne 24.7.2017 v 17:32 Eduardo Habkost napsal(a): > On Mon, Jul 24, 2017 at 02:13:09PM +0200, Lukáš Doktor wrote: >> Dne 21.7.2017 v 20:42 Eduardo Habkost napsal(a): >>> On Fri, Jul 21, 2017 at 08:37:34AM +0200, Lukáš Doktor wrote: Dne 20.7.2017 v 20:27 Eduardo Habkost napsal(a): > On Thu,

Re: [Qemu-devel] [PATCH 05/11] qemu.py: Use custom exceptions rather than Exception

2017-07-24 Thread Eduardo Habkost
On Mon, Jul 24, 2017 at 02:13:09PM +0200, Lukáš Doktor wrote: > Dne 21.7.2017 v 20:42 Eduardo Habkost napsal(a): > > On Fri, Jul 21, 2017 at 08:37:34AM +0200, Lukáš Doktor wrote: > >> Dne 20.7.2017 v 20:27 Eduardo Habkost napsal(a): > >>> On Thu, Jul 20, 2017 at 06:28:09PM +0200, Lukáš Doktor wrote

Re: [Qemu-devel] [PATCH 05/11] qemu.py: Use custom exceptions rather than Exception

2017-07-24 Thread Lukáš Doktor
Dne 21.7.2017 v 20:42 Eduardo Habkost napsal(a): > On Fri, Jul 21, 2017 at 08:37:34AM +0200, Lukáš Doktor wrote: >> Dne 20.7.2017 v 20:27 Eduardo Habkost napsal(a): >>> On Thu, Jul 20, 2017 at 06:28:09PM +0200, Lukáš Doktor wrote: The naked Exception should not be widely used. It makes sense t

Re: [Qemu-devel] [PATCH 05/11] qemu.py: Use custom exceptions rather than Exception

2017-07-21 Thread Eduardo Habkost
On Fri, Jul 21, 2017 at 08:37:34AM +0200, Lukáš Doktor wrote: > Dne 20.7.2017 v 20:27 Eduardo Habkost napsal(a): > > On Thu, Jul 20, 2017 at 06:28:09PM +0200, Lukáš Doktor wrote: > >> The naked Exception should not be widely used. It makes sense to be a > >> bit more specific and use better-suited

Re: [Qemu-devel] [PATCH 05/11] qemu.py: Use custom exceptions rather than Exception

2017-07-20 Thread Lukáš Doktor
Dne 20.7.2017 v 20:27 Eduardo Habkost napsal(a): > On Thu, Jul 20, 2017 at 06:28:09PM +0200, Lukáš Doktor wrote: >> The naked Exception should not be widely used. It makes sense to be a >> bit more specific and use better-suited custom exceptions. As a benefit >> we can store the full reply in the

Re: [Qemu-devel] [PATCH 05/11] qemu.py: Use custom exceptions rather than Exception

2017-07-20 Thread Eduardo Habkost
On Thu, Jul 20, 2017 at 06:28:09PM +0200, Lukáš Doktor wrote: > The naked Exception should not be widely used. It makes sense to be a > bit more specific and use better-suited custom exceptions. As a benefit > we can store the full reply in the exception in case someone needs it > when catching the

[Qemu-devel] [PATCH 05/11] qemu.py: Use custom exceptions rather than Exception

2017-07-20 Thread Lukáš Doktor
The naked Exception should not be widely used. It makes sense to be a bit more specific and use better-suited custom exceptions. As a benefit we can store the full reply in the exception in case someone needs it when catching the exception. Signed-off-by: Lukáš Doktor --- scripts/qemu.py | 17 ++