Re: [Qemu-devel] [PATCH 05/11] pxa2xx_pic: update to use qdev and arm-pic

2011-02-11 Thread andrzej zaborowski
On 11 February 2011 21:18, Dmitry Eremin-Solenikov wrote: > On 2/11/11, andrzej zaborowski wrote: >> On 31 January 2011 16:20, Dmitry Eremin-Solenikov >> wrote: >>> pxa2xx_pic duplicated some code from arm-pic. Drop it, replacing with >>> references to arm-pic. Also use qdev/sysbus framework to

Re: [Qemu-devel] [PATCH 05/11] pxa2xx_pic: update to use qdev and arm-pic

2011-02-11 Thread andrzej zaborowski
Hi, On 11 February 2011 21:24, Dmitry Eremin-Solenikov wrote: > On 2/11/11, Dmitry Eremin-Solenikov wrote: >> I just planned to later reuse allocated arm-pic IRQ's (the new one) to >> be passed to pxa2xx-gpio (to drop usage of cpu-env). I think. I can >> still allocate >> arm-pic but use only th

Re: [Qemu-devel] [PATCH 05/11] pxa2xx_pic: update to use qdev and arm-pic

2011-02-11 Thread Dmitry Eremin-Solenikov
Hello, On 2/11/11, Dmitry Eremin-Solenikov wrote: > On 2/11/11, andrzej zaborowski wrote: >> On 31 January 2011 16:20, Dmitry Eremin-Solenikov >> wrote: >>> pxa2xx_pic duplicated some code from arm-pic. Drop it, replacing with >>> references to arm-pic. Also use qdev/sysbus framework to handle

Re: [Qemu-devel] [PATCH 05/11] pxa2xx_pic: update to use qdev and arm-pic

2011-02-11 Thread Dmitry Eremin-Solenikov
On 2/11/11, andrzej zaborowski wrote: > On 31 January 2011 16:20, Dmitry Eremin-Solenikov > wrote: >> pxa2xx_pic duplicated some code from arm-pic. Drop it, replacing with >> references to arm-pic. Also use qdev/sysbus framework to handle >> pxa2xx-pic. > > The duplication involves about 4 lines

Re: [Qemu-devel] [PATCH 05/11] pxa2xx_pic: update to use qdev and arm-pic

2011-02-10 Thread andrzej zaborowski
On 31 January 2011 16:20, Dmitry Eremin-Solenikov wrote: > pxa2xx_pic duplicated some code from arm-pic. Drop it, replacing with > references to arm-pic. Also use qdev/sysbus framework to handle > pxa2xx-pic. The duplication involves about 4 lines of code, at this level I strongly prefer to not a

[Qemu-devel] [PATCH 05/11] pxa2xx_pic: update to use qdev and arm-pic

2011-01-31 Thread Dmitry Eremin-Solenikov
pxa2xx_pic duplicated some code from arm-pic. Drop it, replacing with references to arm-pic. Also use qdev/sysbus framework to handle pxa2xx-pic. Signed-off-by: Dmitry Eremin-Solenikov --- hw/pxa2xx_pic.c | 125 +-- 1 files changed, 66 inserti