Re: [Qemu-devel] [PATCH 05/11] migration: move vm_old_running into global state

2018-01-03 Thread Peter Xu
On Wed, Jan 03, 2018 at 11:26:12AM +0100, Juan Quintela wrote: > Peter Xu wrote: > > On Wed, Jan 03, 2018 at 10:05:07AM +0100, Juan Quintela wrote: > >> Peter Xu wrote: > >> > Firstly, it was passed around. Let's just move it into MigrationState > >> > just like many other variables as state of

Re: [Qemu-devel] [PATCH 05/11] migration: move vm_old_running into global state

2018-01-03 Thread Juan Quintela
Peter Xu wrote: > On Wed, Jan 03, 2018 at 10:05:07AM +0100, Juan Quintela wrote: >> Peter Xu wrote: >> > Firstly, it was passed around. Let's just move it into MigrationState >> > just like many other variables as state of migration. >> > >> > One thing to mention is that for postcopy, we actual

Re: [Qemu-devel] [PATCH 05/11] migration: move vm_old_running into global state

2018-01-03 Thread Peter Xu
On Wed, Jan 03, 2018 at 10:05:07AM +0100, Juan Quintela wrote: > Peter Xu wrote: > > Firstly, it was passed around. Let's just move it into MigrationState > > just like many other variables as state of migration. > > > > One thing to mention is that for postcopy, we actually don't need this > > k

Re: [Qemu-devel] [PATCH 05/11] migration: move vm_old_running into global state

2018-01-03 Thread Juan Quintela
Peter Xu wrote: > Firstly, it was passed around. Let's just move it into MigrationState > just like many other variables as state of migration. > > One thing to mention is that for postcopy, we actually don't need this > knowledge at all since postcopy can't resume a VM even if it fails (we > can

[Qemu-devel] [PATCH 05/11] migration: move vm_old_running into global state

2018-01-02 Thread Peter Xu
Firstly, it was passed around. Let's just move it into MigrationState just like many other variables as state of migration. One thing to mention is that for postcopy, we actually don't need this knowledge at all since postcopy can't resume a VM even if it fails (we can see that from the old code