Re: [Qemu-devel] [PATCH 05/10] target-arm: Implement setting of watchpoints

2014-08-29 Thread Richard Henderson
On 08/29/2014 04:21 AM, Peter Maydell wrote: > +/* Watchpoint covers an aligned area up to 2GB in size */ > +len = 1ULL << mask; > +/* If masked bits in WVR are not zero it's CONSTRAINED UNPREDICTABLE > + * whether the watchpoint fires when the unmasked bits match; w

Re: [Qemu-devel] [PATCH 05/10] target-arm: Implement setting of watchpoints

2014-08-29 Thread Peter Maydell
On 29 August 2014 17:42, Richard Henderson wrote: > On 08/29/2014 04:21 AM, Peter Maydell wrote: >> +/* Watchpoint covers an aligned area up to 2GB in size */ >> +len = 1ULL << mask; >> +/* If masked bits in WVR are not zero it's CONSTRAINED UNPREDICTABLE >> + * whe

[Qemu-devel] [PATCH 05/10] target-arm: Implement setting of watchpoints

2014-08-29 Thread Peter Maydell
Implement support for setting QEMU watchpoints based on the values the guest writes to the ARM architected watchpoint registers. (We do not yet report the firing of the watchpoints to the guest, so they will just be ignored.) Signed-off-by: Peter Maydell --- target-arm/cpu.c | 2 + targe