On 28/08/2015 16:56, Peter Maydell wrote:
> What's the rationale for this? Mostly we prefer not to
> add ifdefs in code if we can get away with compiling it for
> both cases, even if the resulting code isn't used.
True. The rationale is three-fold:
1) It makes sense to abort if TB_EXIT_ICOUNT_
On 12 August 2015 at 17:40, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> cpu-exec.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/cpu-exec.c b/cpu-exec.c
> index 599e64d..bde5fd1 100644
> --- a/cpu-exec.c
> +++ b/cpu-exec.c
> @@ -228,6 +228,7 @@ static inline tcg_
On 13/08/2015 15:14, Frederic Konrad wrote:
>
>> Signed-off-by: Paolo Bonzini
>> ---
>> cpu-exec.c | 6 ++
>> 1 file changed, 6 insertions(+)
> What about the icount part in CPUState and the tb_start/end ?
> Can't this be removed as well?
Yes, here I'm just dropping the parts that needs
On 12/08/2015 18:40, Paolo Bonzini wrote:
Signed-off-by: Paolo Bonzini
---
cpu-exec.c | 6 ++
1 file changed, 6 insertions(+)
What about the icount part in CPUState and the tb_start/end ?
Can't this be removed as well?
Fred
diff --git a/cpu-exec.c b/cpu-exec.c
index 599e64d..bde5fd1 1
Signed-off-by: Paolo Bonzini
---
cpu-exec.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/cpu-exec.c b/cpu-exec.c
index 599e64d..bde5fd1 100644
--- a/cpu-exec.c
+++ b/cpu-exec.c
@@ -228,6 +228,7 @@ static inline tcg_target_ulong cpu_tb_exec(CPUState *cpu,
uint8_t *tb_ptr)
return