Re: [Qemu-devel] [PATCH 05/10] cpu-exec: elide more icount code if CONFIG_USER_ONLY

2015-08-29 Thread Paolo Bonzini
On 28/08/2015 16:56, Peter Maydell wrote: > What's the rationale for this? Mostly we prefer not to > add ifdefs in code if we can get away with compiling it for > both cases, even if the resulting code isn't used. True. The rationale is three-fold: 1) It makes sense to abort if TB_EXIT_ICOUNT_

Re: [Qemu-devel] [PATCH 05/10] cpu-exec: elide more icount code if CONFIG_USER_ONLY

2015-08-28 Thread Peter Maydell
On 12 August 2015 at 17:40, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > cpu-exec.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/cpu-exec.c b/cpu-exec.c > index 599e64d..bde5fd1 100644 > --- a/cpu-exec.c > +++ b/cpu-exec.c > @@ -228,6 +228,7 @@ static inline tcg_

Re: [Qemu-devel] [PATCH 05/10] cpu-exec: elide more icount code if CONFIG_USER_ONLY

2015-08-13 Thread Paolo Bonzini
On 13/08/2015 15:14, Frederic Konrad wrote: > >> Signed-off-by: Paolo Bonzini >> --- >> cpu-exec.c | 6 ++ >> 1 file changed, 6 insertions(+) > What about the icount part in CPUState and the tb_start/end ? > Can't this be removed as well? Yes, here I'm just dropping the parts that needs

Re: [Qemu-devel] [PATCH 05/10] cpu-exec: elide more icount code if CONFIG_USER_ONLY

2015-08-13 Thread Frederic Konrad
On 12/08/2015 18:40, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- cpu-exec.c | 6 ++ 1 file changed, 6 insertions(+) What about the icount part in CPUState and the tb_start/end ? Can't this be removed as well? Fred diff --git a/cpu-exec.c b/cpu-exec.c index 599e64d..bde5fd1 1

[Qemu-devel] [PATCH 05/10] cpu-exec: elide more icount code if CONFIG_USER_ONLY

2015-08-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- cpu-exec.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/cpu-exec.c b/cpu-exec.c index 599e64d..bde5fd1 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -228,6 +228,7 @@ static inline tcg_target_ulong cpu_tb_exec(CPUState *cpu, uint8_t *tb_ptr) return