[Qemu-devel] [PATCH 04/32] vvfat: Do not clobber the user's geometry

2012-07-06 Thread Markus Armbruster
vvfat creates a virtual VFAT filesystem with a certain logical geometry that depends on its options. It sets the "geometry hint" to this geometry. It is the only block driver to do this. The geometry hint is about about *physical* geometry, and used only by certain hard disk device models. vvfa

Re: [Qemu-devel] [PATCH 04/32] vvfat: Do not clobber the user's geometry

2012-07-05 Thread Markus Armbruster
Kevin Wolf writes: > Am 29.06.2012 17:34, schrieb Markus Armbruster: [...] >> @@ -1067,19 +1074,16 @@ DLOG(if (stderr == NULL) { >> else >> dirname += i+1; >> >> -bs->total_sectors=bs->cyls*bs->heads*bs->secs; >> +bs->total_sectors = cyls * heads * secs; >> >> -if(init_d

Re: [Qemu-devel] [PATCH 04/32] vvfat: Do not clobber the user's geometry

2012-07-05 Thread Markus Armbruster
Kevin Wolf writes: > Am 04.07.2012 18:25, schrieb Paolo Bonzini: >> Il 04/07/2012 17:23, Kevin Wolf ha scritto: > optsLCHSdef. PCHS >:floppy: 80, 2,36 5,16,63 > :32:floppy: 80, 2,36 5,16,63 > :16:floppy: 80, 2,36 5,16,63 > :12:f

Re: [Qemu-devel] [PATCH 04/32] vvfat: Do not clobber the user's geometry

2012-07-05 Thread Kevin Wolf
Am 04.07.2012 18:25, schrieb Paolo Bonzini: > Il 04/07/2012 17:23, Kevin Wolf ha scritto: optsLCHSdef. PCHS :floppy: 80, 2,36 5,16,63 :32:floppy: 80, 2,36 5,16,63 :16:floppy: 80, 2,36 5,16,63 :12:floppy: 80, 2,18 2,16,63 >>

Re: [Qemu-devel] [PATCH 04/32] vvfat: Do not clobber the user's geometry

2012-07-04 Thread Paolo Bonzini
Il 04/07/2012 17:23, Kevin Wolf ha scritto: >> > optsLCHSdef. PCHS >> >:floppy: 80, 2,36 5,16,63 >> > :32:floppy: 80, 2,36 5,16,63 >> > :16:floppy: 80, 2,36 5,16,63 >> > :12:floppy: 80, 2,18 2,16,63 >> > >> > Silly thing to do for use with a hard

Re: [Qemu-devel] [PATCH 04/32] vvfat: Do not clobber the user's geometry

2012-07-04 Thread Kevin Wolf
Am 29.06.2012 17:34, schrieb Markus Armbruster: > vvfat creates a virtual VFAT filesystem with a certain logical > geometry that depends on its options. It sets the "geometry hint" to > this geometry. It is the only block driver to do this. > > The geometry hint is about about *physical* geometr

[Qemu-devel] [PATCH 04/32] vvfat: Do not clobber the user's geometry

2012-06-29 Thread Markus Armbruster
vvfat creates a virtual VFAT filesystem with a certain logical geometry that depends on its options. It sets the "geometry hint" to this geometry. It is the only block driver to do this. The geometry hint is about about *physical* geometry, and used only by certain hard disk device models. vvfa