Re: [Qemu-devel] [PATCH 04/22] display: enable DIRTY_MEMORY_VGA tracking explicitly

2015-04-22 Thread Stefan Hajnoczi
On Mon, Apr 20, 2015 at 03:54:52PM +0200, Paolo Bonzini wrote: > > > On 20/04/2015 15:11, Stefan Hajnoczi wrote: > >> -memory_region_set_coalescing(&s->mem_vram); + > >> memory_region_set_log(&s->mem_vram, true, DIRTY_MEMORY_VGA); > > > > This change isn't 100% clear to me. I guess that coa

Re: [Qemu-devel] [PATCH 04/22] display: enable DIRTY_MEMORY_VGA tracking explicitly

2015-04-20 Thread Paolo Bonzini
On 20/04/2015 15:11, Stefan Hajnoczi wrote: >> -memory_region_set_coalescing(&s->mem_vram); + >> memory_region_set_log(&s->mem_vram, true, DIRTY_MEMORY_VGA); > > This change isn't 100% clear to me. I guess that coalescing > (performance optimization) doesn't make sense when logging is > en

Re: [Qemu-devel] [PATCH 04/22] display: enable DIRTY_MEMORY_VGA tracking explicitly

2015-04-20 Thread Stefan Hajnoczi
On Thu, Mar 26, 2015 at 06:38:22PM +0100, Paolo Bonzini wrote: > diff --git a/hw/display/g364fb.c b/hw/display/g364fb.c > index 46f7b41..be62dd6 100644 > --- a/hw/display/g364fb.c > +++ b/hw/display/g364fb.c > @@ -489,7 +489,7 @@ static void g364fb_init(DeviceState *dev, G364State *s) > memory

[Qemu-devel] [PATCH 04/22] display: enable DIRTY_MEMORY_VGA tracking explicitly

2015-03-26 Thread Paolo Bonzini
This will be required soon by the memory core. Signed-off-by: Paolo Bonzini --- hw/display/cg3.c | 1 + hw/display/exynos4210_fimd.c | 7 ++- hw/display/g364fb.c | 2 +- hw/display/sm501.c | 1 + hw/display/tcx.c | 1 + 5 files changed, 10 insertion