Re: [Qemu-devel] [PATCH 04/18] nbd/client: refactor nbd_receive_starttls

2017-02-20 Thread Eric Blake
On 02/11/2017 01:30 PM, Eric Blake wrote: > On 02/03/2017 09:47 AM, Vladimir Sementsov-Ogievskiy wrote: >> Split out nbd_receive_simple_option to be reused for structured reply >> option. >> +return ""; > Can you please consider making this include the %d representation of >

Re: [Qemu-devel] [PATCH 04/18] nbd/client: refactor nbd_receive_starttls

2017-02-13 Thread Eric Blake
On 02/10/2017 05:23 AM, Vladimir Sementsov-Ogievskiy wrote: > 09.02.2017 17:41, Eric Blake wrote: >> On 02/09/2017 12:20 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 07.02.2017 19:32, Eric Blake wrote: On 02/03/2017 09:47 AM, Vladimir Sementsov-Ogievskiy wrote: > Split out nbd_receive_simpl

Re: [Qemu-devel] [PATCH 04/18] nbd/client: refactor nbd_receive_starttls

2017-02-10 Thread Vladimir Sementsov-Ogievskiy
09.02.2017 17:41, Eric Blake wrote: On 02/09/2017 12:20 AM, Vladimir Sementsov-Ogievskiy wrote: 07.02.2017 19:32, Eric Blake wrote: On 02/03/2017 09:47 AM, Vladimir Sementsov-Ogievskiy wrote: Split out nbd_receive_simple_option to be reused for structured reply option. +return ""; Can you

Re: [Qemu-devel] [PATCH 04/18] nbd/client: refactor nbd_receive_starttls

2017-02-09 Thread Eric Blake
On 02/09/2017 12:20 AM, Vladimir Sementsov-Ogievskiy wrote: > 07.02.2017 19:32, Eric Blake wrote: >> On 02/03/2017 09:47 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Split out nbd_receive_simple_option to be reused for structured reply >>> option. >>> +return ""; >> Can you please consider maki

Re: [Qemu-devel] [PATCH 04/18] nbd/client: refactor nbd_receive_starttls

2017-02-08 Thread Vladimir Sementsov-Ogievskiy
07.02.2017 19:32, Eric Blake wrote: On 02/03/2017 09:47 AM, Vladimir Sementsov-Ogievskiy wrote: Split out nbd_receive_simple_option to be reused for structured reply option. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/client.c | 54 +++---

Re: [Qemu-devel] [PATCH 04/18] nbd/client: refactor nbd_receive_starttls

2017-02-07 Thread Eric Blake
On 02/03/2017 09:47 AM, Vladimir Sementsov-Ogievskiy wrote: > Split out nbd_receive_simple_option to be reused for structured reply > option. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/client.c | 54 > +++--- > nbd/nbd-inter

[Qemu-devel] [PATCH 04/18] nbd/client: refactor nbd_receive_starttls

2017-02-03 Thread Vladimir Sementsov-Ogievskiy
Split out nbd_receive_simple_option to be reused for structured reply option. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/client.c | 54 +++--- nbd/nbd-internal.h | 14 ++ 2 files changed, 49 insertions(+), 19 deletions(-)