Re: [Qemu-devel] [PATCH 04/17] virtio-9p: Implement P9_TSTAT

2010-03-11 Thread Paul Brook
> Paul Brook wrote: > >> Is there any reason (other than being coding style) in using > >> qemu_free() instead of free()? As per qem-malloc.c qemu_free() is > >> nothing but free(). > > > > The whole point of qemu_{malloc,free} is to isolate code from the system > > implementation of malloc/free.

Re: [Qemu-devel] [PATCH 04/17] virtio-9p: Implement P9_TSTAT

2010-03-09 Thread Aneesh Kumar K. V
On Tue, 9 Mar 2010 12:30:08 +, Paul Brook wrote: > > Is there any reason (other than being coding style) in using qemu_free() > > instead of free()? As per qem-malloc.c qemu_free() is nothing but free(). > > The whole point of qemu_{malloc,free} is to isolate code from the system > implemen

Re: [Qemu-devel] [PATCH 04/17] virtio-9p: Implement P9_TSTAT

2010-03-09 Thread jvrao
Paul Brook wrote: >> Is there any reason (other than being coding style) in using qemu_free() >> instead of free()? As per qem-malloc.c qemu_free() is nothing but free(). > > The whole point of qemu_{malloc,free} is to isolate code from the system > implementation of malloc/free. It's entirely p

Re: [Qemu-devel] [PATCH 04/17] virtio-9p: Implement P9_TSTAT

2010-03-09 Thread Paul Brook
> Is there any reason (other than being coding style) in using qemu_free() > instead of free()? As per qem-malloc.c qemu_free() is nothing but free(). The whole point of qemu_{malloc,free} is to isolate code from the system implementation of malloc/free. It's entirely possible that future versio

Re: [Qemu-devel] [PATCH 04/17] virtio-9p: Implement P9_TSTAT

2010-03-08 Thread jvrao
Aneesh Kumar K. V wrote: > On Wed, 3 Mar 2010 23:35:36 +0300 (MSK), malc wrote: >> On Wed, 3 Mar 2010, Anthony Liguori wrote: >> >>> This get the mount to work on the guest >>> >>> [ki...@linux.vnet.ibm.com: malloc to qemu_malloc conversion] >>> >>> Signed-off-by: Anthony Liguori >>> Signed-off-b

Re: [Qemu-devel] [PATCH 04/17] virtio-9p: Implement P9_TSTAT

2010-03-04 Thread Aneesh Kumar K. V
On Wed, 3 Mar 2010 23:35:36 +0300 (MSK), malc wrote: > On Wed, 3 Mar 2010, Anthony Liguori wrote: > > > This get the mount to work on the guest > > > > [ki...@linux.vnet.ibm.com: malloc to qemu_malloc conversion] > > > > Signed-off-by: Anthony Liguori > > Signed-off-by: Gautham R Shenoy > > S

Re: [Qemu-devel] [PATCH 04/17] virtio-9p: Implement P9_TSTAT

2010-03-03 Thread malc
On Wed, 3 Mar 2010, Anthony Liguori wrote: > This get the mount to work on the guest > > [ki...@linux.vnet.ibm.com: malloc to qemu_malloc conversion] > > Signed-off-by: Anthony Liguori > Signed-off-by: Gautham R Shenoy > Signed-off-by: Aneesh Kumar K.V > --- > hw/virtio-9p-local.c |7 ++

[Qemu-devel] [PATCH 04/17] virtio-9p: Implement P9_TSTAT

2010-03-03 Thread Anthony Liguori
This get the mount to work on the guest [ki...@linux.vnet.ibm.com: malloc to qemu_malloc conversion] Signed-off-by: Anthony Liguori Signed-off-by: Gautham R Shenoy Signed-off-by: Aneesh Kumar K.V --- hw/virtio-9p-local.c |7 ++ hw/virtio-9p.c | 169 +