Am 24.09.2013 um 12:41 hat Paolo Bonzini geschrieben:
> Il 20/09/2013 16:01, Benoît Canet ha scritto:
> >> > +if (error_is_set(&local_err)) {
> >> > +error_propagate(errp, local_err);
> >> > +goto fail;
> > There is nothing to execute between error_propagate and fail: maybe we c
Il 20/09/2013 16:01, Benoît Canet ha scritto:
>> > +if (error_is_set(&local_err)) {
>> > +error_propagate(errp, local_err);
>> > +goto fail;
> There is nothing to execute between error_propagate and fail: maybe we could
> get rid of the goto.
Or perhaps of the "else".
Paolo
>
Il 20/09/2013 13:54, Kevin Wolf ha scritto:
> + * For now, simply forbidding the combination for all drivers will do. */
> +if (options->has_aio && options->aio == BLOCKDEV_A_I_O_OPTIONS_NATIVE) {
Let's call it BlockdevAioOptions instead?
Paolo
> +bool direct = options->cache->h
Am 24.09.2013 um 07:18 hat Fam Zheng geschrieben:
> On Fri, 09/20 13:54, Kevin Wolf wrote:
> > For examples see the changes to qmp-commands.hx.
> >
> > Signed-off-by: Kevin Wolf
> > ---
> > blockdev.c | 57
> > qapi-schema.json | 270
> > +
On Fri, 09/20 13:54, Kevin Wolf wrote:
> For examples see the changes to qmp-commands.hx.
>
> Signed-off-by: Kevin Wolf
> ---
> blockdev.c | 57
> qapi-schema.json | 270
> +++
> qmp-commands.hx | 59
> 3 fil
On 09/20/2013 05:54 AM, Kevin Wolf wrote:
> For examples see the changes to qmp-commands.hx.
>
> Signed-off-by: Kevin Wolf
> ---
> blockdev.c | 57
> qapi-schema.json | 270
> +++
> qmp-commands.hx | 59
> 3
Am 20.09.2013 um 17:22 hat Eric Blake geschrieben:
> On 09/20/2013 05:54 AM, Kevin Wolf wrote:
> > For examples see the changes to qmp-commands.hx.
> >
> > Signed-off-by: Kevin Wolf
> > ---
> > blockdev.c | 57
> > qapi-schema.json | 270
> > +
Am 20.09.2013 um 15:34 hat Max Reitz geschrieben:
> On 2013-09-20 13:54, Kevin Wolf wrote:
> >For examples see the changes to qmp-commands.hx.
> >
> >Signed-off-by: Kevin Wolf
> >+{ 'type': 'BlockdevThrottlingOptions',
> >+ 'data': { '*bps-total': 'int',
> >+'*bps-read': 'int',
> >+
Le Friday 20 Sep 2013 à 13:54:17 (+0200), Kevin Wolf a écrit :
> For examples see the changes to qmp-commands.hx.
>
> Signed-off-by: Kevin Wolf
> ---
> blockdev.c | 57
> qapi-schema.json | 270
> +++
> qmp-commands.hx |
On 2013-09-20 13:54, Kevin Wolf wrote:
For examples see the changes to qmp-commands.hx.
Signed-off-by: Kevin Wolf
---
blockdev.c | 57
qapi-schema.json | 270 +++
qmp-commands.hx | 59
3 files changed, 3
For examples see the changes to qmp-commands.hx.
Signed-off-by: Kevin Wolf
---
blockdev.c | 57
qapi-schema.json | 270 +++
qmp-commands.hx | 59
3 files changed, 386 insertions(+)
diff --git a/blockdev.c b/b
11 matches
Mail list logo
