Re: [Qemu-devel] [PATCH 04/16] qapi: introduce OptsVisitor

2012-06-06 Thread Paolo Bonzini
Il 06/06/2012 13:12, Laszlo Ersek ha scritto: > The unsigned functions don't check if the int64_t value to be assigned is > negative. What happens in such a case is fully defined, but did Michael > really intend the wraparound to unsigned? I think that's a bug. Please coordinate with Michael and

Re: [Qemu-devel] [PATCH 04/16] qapi: introduce OptsVisitor

2012-06-06 Thread Laszlo Ersek
Thank you very much for the review! One question below (and maybe some more later in response to other parts of the review): On 06/05/12 23:12, Paolo Bonzini wrote: > Il 22/05/2012 12:45, Laszlo Ersek ha scritto: >> Optarg values can be of scalar types str / bool / int / size. > > Michael Roth r

Re: [Qemu-devel] [PATCH 04/16] qapi: introduce OptsVisitor

2012-06-05 Thread Paolo Bonzini
Il 22/05/2012 12:45, Laszlo Ersek ha scritto: > This visitor supports parsing > > -option [type=]discriminator[,optarg1=val1][,optarg2=val2][,...] > > style QemuOpts objects into "native" C structures. After defining the type > tree in the qapi schema (see below), a root type traversal with thi

[Qemu-devel] [PATCH 04/16] qapi: introduce OptsVisitor

2012-05-22 Thread Laszlo Ersek
This visitor supports parsing -option [type=]discriminator[,optarg1=val1][,optarg2=val2][,...] style QemuOpts objects into "native" C structures. After defining the type tree in the qapi schema (see below), a root type traversal with this visitor linked to the underlying QemuOpts object will bu