Re: [Qemu-devel] [PATCH 04/14] virtio-net: avoid sg copy

2012-09-24 Thread Michael S. Tsirkin
On Mon, Sep 24, 2012 at 07:37:40PM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > Avoid tweaking iovec during receive. This removes > > the need to copy the vector. > > Note: we already have an evil cast in work_around_broken_dhclient > > and unfortunately this adds another on

Re: [Qemu-devel] [PATCH 04/14] virtio-net: avoid sg copy

2012-09-24 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > Avoid tweaking iovec during receive. This removes > the need to copy the vector. > Note: we already have an evil cast in work_around_broken_dhclient > and unfortunately this adds another one. > const on buf is ignored by this function anyway so arguably > this is no

[Qemu-devel] [PATCH 04/14] virtio-net: avoid sg copy

2012-09-24 Thread Michael S. Tsirkin
Avoid tweaking iovec during receive. This removes the need to copy the vector. Note: we already have an evil cast in work_around_broken_dhclient and unfortunately this adds another one. const on buf is ignored by this function anyway so arguably this is not making things much worse. Signed-off-by: