Re: [Qemu-devel] [PATCH 04/12] monitor: remove usage of generated marshal functions

2016-06-24 Thread Eric Blake
On 06/24/2016 08:14 AM, Marc-André Lureau wrote: > Hi > > On Fri, Jun 24, 2016 at 6:23 AM, Eric Blake wrote: >>> >>> -static bool invalid_qmp_mode(const Monitor *mon, const mon_cmd_t *cmd, >>> +static bool invalid_qmp_mode(const Monitor *mon, const gchar *cmd, >> >> Why 'gchar'? What's wrong wit

Re: [Qemu-devel] [PATCH 04/12] monitor: remove usage of generated marshal functions

2016-06-24 Thread Marc-André Lureau
Hi On Fri, Jun 24, 2016 at 6:23 AM, Eric Blake wrote: >> >> -static bool invalid_qmp_mode(const Monitor *mon, const mon_cmd_t *cmd, >> +static bool invalid_qmp_mode(const Monitor *mon, const gchar *cmd, > > Why 'gchar'? What's wrong with 'char'? (Some of glib's typedefs make > sense, but gchar

Re: [Qemu-devel] [PATCH 04/12] monitor: remove usage of generated marshal functions

2016-06-23 Thread Eric Blake
On 06/22/2016 06:08 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Once the middle mode is removed, the generated marshal functions will no > longer be exported. > > Signed-off-by: Marc-André Lureau > --- > monitor.c | 10 +- > 1 file changed, 5 insertions(+), 5 d

[Qemu-devel] [PATCH 04/12] monitor: remove usage of generated marshal functions

2016-06-22 Thread marcandre . lureau
From: Marc-André Lureau Once the middle mode is removed, the generated marshal functions will no longer be exported. Signed-off-by: Marc-André Lureau --- monitor.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/monitor.c b/monitor.c index fc691b9..585bc1f 100644