Re: [Qemu-devel] [PATCH 04/11] migration: split use of MigrationState.total_time

2018-01-03 Thread Peter Xu
On Wed, Jan 03, 2018 at 10:20:39AM +0100, Juan Quintela wrote: > Peter Xu wrote: > > On Wed, Jan 03, 2018 at 09:58:10AM +0100, Juan Quintela wrote: > >> Peter Xu wrote: > >> > It was used either to: > >> > > >> > 1. store initial timestamp of migration start, and > >> > 2. store total time used b

Re: [Qemu-devel] [PATCH 04/11] migration: split use of MigrationState.total_time

2018-01-03 Thread Juan Quintela
Peter Xu wrote: > On Wed, Jan 03, 2018 at 09:58:10AM +0100, Juan Quintela wrote: >> Peter Xu wrote: >> > It was used either to: >> > >> > 1. store initial timestamp of migration start, and >> > 2. store total time used by last migration >> > >> > Let's provide two parameters for each of them. Mi

Re: [Qemu-devel] [PATCH 04/11] migration: split use of MigrationState.total_time

2018-01-03 Thread Peter Xu
On Wed, Jan 03, 2018 at 09:58:10AM +0100, Juan Quintela wrote: > Peter Xu wrote: > > It was used either to: > > > > 1. store initial timestamp of migration start, and > > 2. store total time used by last migration > > > > Let's provide two parameters for each of them. Mix use of the two is > > sl

Re: [Qemu-devel] [PATCH 04/11] migration: split use of MigrationState.total_time

2018-01-03 Thread Juan Quintela
Peter Xu wrote: > It was used either to: > > 1. store initial timestamp of migration start, and > 2. store total time used by last migration > > Let's provide two parameters for each of them. Mix use of the two is > slightly misleading. > > Signed-off-by: Peter Xu Reviewed-by: Juan Quintela I

[Qemu-devel] [PATCH 04/11] migration: split use of MigrationState.total_time

2018-01-02 Thread Peter Xu
It was used either to: 1. store initial timestamp of migration start, and 2. store total time used by last migration Let's provide two parameters for each of them. Mix use of the two is slightly misleading. Signed-off-by: Peter Xu --- migration/migration.c | 13 +++-- migration/migrat