Re: [Qemu-devel] [PATCH 04/11] migration: return real error code

2011-10-05 Thread Juan Quintela
Anthony Liguori wrote: > On 10/04/2011 01:35 PM, Juan Quintela wrote: >> Anthony Liguori wrote: >>> On 09/23/2011 07:50 AM, Juan Quintela wrote: make functions propaget errno, instead of just using -EIO. Signed-off-by: Juan Quintela >>> >>> qemu_file_has_error() implies a boolean r

Re: [Qemu-devel] [PATCH 04/11] migration: return real error code

2011-10-05 Thread Anthony Liguori
On 10/04/2011 01:35 PM, Juan Quintela wrote: Anthony Liguori wrote: On 09/23/2011 07:50 AM, Juan Quintela wrote: make functions propaget errno, instead of just using -EIO. Signed-off-by: Juan Quintela qemu_file_has_error() implies a boolean response. Wouldn't qemu_file_get_error() make mor

Re: [Qemu-devel] [PATCH 04/11] migration: return real error code

2011-10-04 Thread Juan Quintela
Anthony Liguori wrote: > On 09/23/2011 07:50 AM, Juan Quintela wrote: >> make functions propaget errno, instead of just using -EIO. >> >> Signed-off-by: Juan Quintela > > qemu_file_has_error() implies a boolean response. Wouldn't > qemu_file_get_error() make more sense if you're going to rely on

Re: [Qemu-devel] [PATCH 04/11] migration: return real error code

2011-10-04 Thread Anthony Liguori
On 09/23/2011 07:50 AM, Juan Quintela wrote: make functions propaget errno, instead of just using -EIO. Signed-off-by: Juan Quintela qemu_file_has_error() implies a boolean response. Wouldn't qemu_file_get_error() make more sense if you're going to rely on the return value? Regards, Antho

[Qemu-devel] [PATCH 04/11] migration: return real error code

2011-09-23 Thread Juan Quintela
make functions propaget errno, instead of just using -EIO. Signed-off-by: Juan Quintela --- migration.c |6 +- savevm.c| 33 +++-- 2 files changed, 20 insertions(+), 19 deletions(-) diff --git a/migration.c b/migration.c index ea7bcc8..9498e20 100644 --