Re: [Qemu-devel] [PATCH 04/11] block: Support streaming to an intermediate layer

2015-05-15 Thread Fam Zheng
On Fri, 05/15 11:04, Alberto Garcia wrote: > On Fri 15 May 2015 04:33:19 AM CEST, Fam Zheng wrote: > > >> +/* Make sure that the image is opened in read-write mode */ > >> +orig_bs_flags = bdrv_get_flags(bs); > >> +if (!(orig_bs_flags & BDRV_O_RDWR)) { > >> +if (bdrv_reopen(bs,

Re: [Qemu-devel] [PATCH 04/11] block: Support streaming to an intermediate layer

2015-05-15 Thread Alberto Garcia
On Fri 15 May 2015 04:33:19 AM CEST, Fam Zheng wrote: >> +/* Make sure that the image is opened in read-write mode */ >> +orig_bs_flags = bdrv_get_flags(bs); >> +if (!(orig_bs_flags & BDRV_O_RDWR)) { >> +if (bdrv_reopen(bs, orig_bs_flags | BDRV_O_RDWR, errp) != 0) { > > I don't

Re: [Qemu-devel] [PATCH 04/11] block: Support streaming to an intermediate layer

2015-05-14 Thread Fam Zheng
On Wed, 05/13 16:27, Alberto Garcia wrote: > This makes sure that the image we are steaming into is open in > read-write mode during the operation. > > Operation blockers are also set in all intermediate nodes, since they > will be removed from the chain afterwards. > > Finally, this also unblock

[Qemu-devel] [PATCH 04/11] block: Support streaming to an intermediate layer

2015-05-13 Thread Alberto Garcia
This makes sure that the image we are steaming into is open in read-write mode during the operation. Operation blockers are also set in all intermediate nodes, since they will be removed from the chain afterwards. Finally, this also unblocks the stream operation in backing files. Signed-off-by:

[Qemu-devel] [PATCH 04/11] block: Support streaming to an intermediate layer

2015-04-24 Thread Alberto Garcia
This makes sure that the image we are steaming into is open in read-write mode during the operation. Operation blockers are also set in all intermediate nodes, since they will be removed from the chain afterwards. Finally, this also unblocks the stream operation in backing files. Signed-off-by:

[Qemu-devel] [PATCH 04/11] block: Support streaming to an intermediate layer

2015-04-24 Thread Alberto Garcia
This makes sure that the image we are steaming into is open in read-write mode during the operation. Operation blockers are also set in all intermediate nodes, since they will be removed from the chain afterwards. Finally, this also unblocks the stream operation in backing files. Signed-off-by: