Re: [Qemu-devel] [PATCH 04/10] tcg/mips: don't use global pointer

2012-09-21 Thread Aurelien Jarno
On Fri, Sep 21, 2012 at 11:18:39AM -0700, Richard Henderson wrote: > On 09/21/2012 09:43 AM, Aurelien Jarno wrote: > > Don't use the global pointer in TCG, in case helpers try access global > > variables. > > Err.. isn't the GP computed at the entry point of functions that need to use > it? I re

Re: [Qemu-devel] [PATCH 04/10] tcg/mips: don't use global pointer

2012-09-21 Thread Richard Henderson
On 09/21/2012 09:43 AM, Aurelien Jarno wrote: > Don't use the global pointer in TCG, in case helpers try access global > variables. Err.. isn't the GP computed at the entry point of functions that need to use it? That said, under n32 and n64 abis it is call-saved; under o32 it's call-clobbered.

[Qemu-devel] [PATCH 04/10] tcg/mips: don't use global pointer

2012-09-21 Thread Aurelien Jarno
Don't use the global pointer in TCG, in case helpers try access global variables. Signed-off-by: Aurelien Jarno --- tcg/mips/tcg-target.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c index 8b38f98..0ea6a76 100644 --- a/tcg/m