Re: [Qemu-devel] [PATCH 04/10] XBZRLE: rebuild the cache_is_cached function

2014-03-11 Thread Juan Quintela
wrote: > From: ChenLiang > > Rebuild the cache_is_cached function. Why? > +bool cache_is_cached(const PageCache *cache, uint64_t addr, > + uint64_t current_age) > +{ > +CacheItem *it = NULL; s/= NULL// Thanks, Juan. > + > +it = cache_get_by_addr(cache, addr); > +

Re: [Qemu-devel] [PATCH 04/10] XBZRLE: rebuild the cache_is_cached function

2014-03-11 Thread Eric Blake
On 03/11/2014 06:53 AM, arei.gong...@huawei.com wrote: > From: ChenLiang > > Rebuild the cache_is_cached function. > > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > Reviewed-by: Dr. David Alan Gilbert > Reviewed-by: Eric Blake Once again, I did NOT give R-b in v1. > --- > page_cache

[Qemu-devel] [PATCH 04/10] XBZRLE: rebuild the cache_is_cached function

2014-03-11 Thread arei.gonglei
From: ChenLiang Rebuild the cache_is_cached function. Signed-off-by: ChenLiang Signed-off-by: Gonglei Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Eric Blake --- page_cache.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/page_cac