Re: [Qemu-devel] [PATCH 03/39] vga: convert vga and its derivatives to the memory API

2011-07-31 Thread Avi Kivity
On 07/31/2011 09:48 PM, Jan Kiszka wrote: > > I haven't. How does "unconditionally dirty the remapped slot" sound? > > I think it isn't introduced by this patchset, yes? The patch removes the explicit sync from the cirrus code. But the underlying issue is older of course. Ah. So I'll dete

[Qemu-devel] [PATCH 03/39] vga: convert vga and its derivatives to the memory API

2011-07-31 Thread Avi Kivity
Convert all vga memory to the memory API. Note we need to fall back to get_system_memory(), since the various buses don't pass the vga window as a memory region. We no longer need to sync the dirty bitmap of the cirrus mapped memory banks, since the memory API takes care of that for us. [jan: fi

Re: [Qemu-devel] [PATCH 03/39] vga: convert vga and its derivatives to the memory API

2011-07-31 Thread Jan Kiszka
On 2011-07-31 20:46, Avi Kivity wrote: > On 07/31/2011 09:42 PM, Jan Kiszka wrote: >> On 2011-07-31 19:57, Avi Kivity wrote: >> > Convert all vga memory to the memory API. Note we need to fall >> back to >> > get_system_memory(), since the various buses don't pass the vga window >> > as a memor

Re: [Qemu-devel] [PATCH 03/39] vga: convert vga and its derivatives to the memory API

2011-07-31 Thread Avi Kivity
On 07/31/2011 09:42 PM, Jan Kiszka wrote: On 2011-07-31 19:57, Avi Kivity wrote: > Convert all vga memory to the memory API. Note we need to fall back to > get_system_memory(), since the various buses don't pass the vga window > as a memory region. > > We no longer need to sync the dirty bit

Re: [Qemu-devel] [PATCH 03/39] vga: convert vga and its derivatives to the memory API

2011-07-31 Thread Jan Kiszka
On 2011-07-31 19:57, Avi Kivity wrote: > Convert all vga memory to the memory API. Note we need to fall back to > get_system_memory(), since the various buses don't pass the vga window > as a memory region. > > We no longer need to sync the dirty bitmap of the cirrus mapped memory > banks, since