Re: [Qemu-devel] [PATCH 03/32] lsi: use qdev_reset_all

2013-04-23 Thread Jan Kiszka
On 2013-04-23 18:43, Paolo Bonzini wrote: > Il 23/04/2013 18:13, Paolo Bonzini ha scritto: >> Il 23/04/2013 10:47, Jan Kiszka ha scritto: > if (val & LSI_ISTAT0_SRST) { > -lsi_soft_reset(s); > +qdev_reset_all(&s->dev.qdev); >>> What should ensure that al

Re: [Qemu-devel] [PATCH 03/32] lsi: use qdev_reset_all

2013-04-23 Thread Paolo Bonzini
Il 23/04/2013 18:13, Paolo Bonzini ha scritto: > Il 23/04/2013 10:47, Jan Kiszka ha scritto: if (val & LSI_ISTAT0_SRST) { -lsi_soft_reset(s); +qdev_reset_all(&s->dev.qdev); >> What should ensure that all device resets are performed before the host >>

Re: [Qemu-devel] [PATCH 03/32] lsi: use qdev_reset_all

2013-04-23 Thread Paolo Bonzini
Il 23/04/2013 10:47, Jan Kiszka ha scritto: >> > if (val & LSI_ISTAT0_SRST) { >> > -lsi_soft_reset(s); >> > +qdev_reset_all(&s->dev.qdev); > What should ensure that all device resets are performed before the host > reset? I'm asking as we just ran into the assert(!s

Re: [Qemu-devel] [PATCH 03/32] lsi: use qdev_reset_all

2013-04-23 Thread Jan Kiszka
On 2012-07-27 17:02, Paolo Bonzini wrote: > By first resetting the devices, lsi_soft_reset will find the queue > already cleared so there is no need to do that forcibly (which may also > leak SCSIRequests, and/or worse due to dangling references to the > lsi_request in the hba_private field). > >

[Qemu-devel] [PATCH 03/32] lsi: use qdev_reset_all

2012-07-27 Thread Paolo Bonzini
By first resetting the devices, lsi_soft_reset will find the queue already cleared so there is no need to do that forcibly (which may also leak SCSIRequests, and/or worse due to dangling references to the lsi_request in the hba_private field). Signed-off-by: Paolo Bonzini --- hw/lsi53c895a.c |