Re: [Qemu-devel] [PATCH 03/22] qapi: add Error object

2011-03-07 Thread Anthony Liguori
On 03/07/2011 05:06 AM, Daniel P. Berrange wrote: On Sun, Mar 06, 2011 at 07:22:45PM -0600, Anthony Liguori wrote: The Error class is similar to QError (now deprecated) except that it supports propagation. This allows for higher quality error handling. It's losely modeled after glib style

Re: [Qemu-devel] [PATCH 03/22] qapi: add Error object

2011-03-07 Thread Anthony Liguori
On 03/07/2011 05:06 AM, Daniel P. Berrange wrote: On Sun, Mar 06, 2011 at 07:22:45PM -0600, Anthony Liguori wrote: The Error class is similar to QError (now deprecated) except that it supports propagation. This allows for higher quality error handling. It's losely modeled after glib style

Re: [Qemu-devel] [PATCH 03/22] qapi: add Error object

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 1:36 PM, Anthony Liguori wrote: > On 03/07/2011 05:38 AM, Stefan Hajnoczi wrote: >> >> On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori >>  wrote: >> >>> >>> +struct Error >>> +{ >>> +    QDict *obj; >>> +    const char *fmt; >>> +    char *msg; >>> +}; >>> >> >> I wonder why

Re: [Qemu-devel] [PATCH 03/22] qapi: add Error object

2011-03-07 Thread Anthony Liguori
On 03/07/2011 05:38 AM, Stefan Hajnoczi wrote: On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: +struct Error +{ +QDict *obj; +const char *fmt; +char *msg; +}; I wonder why fmt is const char * but msg is char *. Users should use error_get_pretty() instead of access

Re: [Qemu-devel] [PATCH 03/22] qapi: add Error object

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: > +struct Error > +{ > +    QDict *obj; > +    const char *fmt; > +    char *msg; > +}; I wonder why fmt is const char * but msg is char *. Users should use error_get_pretty() instead of accessing msg directly and that function returns const

Re: [Qemu-devel] [PATCH 03/22] qapi: add Error object

2011-03-07 Thread Daniel P. Berrange
On Sun, Mar 06, 2011 at 07:22:45PM -0600, Anthony Liguori wrote: > The Error class is similar to QError (now deprecated) except that it supports > propagation. This allows for higher quality error handling. It's losely > modeled after glib style GErrors. I know this offers more functionality tha

[Qemu-devel] [PATCH 03/22] qapi: add Error object

2011-03-06 Thread Anthony Liguori
The Error class is similar to QError (now deprecated) except that it supports propagation. This allows for higher quality error handling. It's losely modeled after glib style GErrors. Signed-off-by: Anthony Liguori diff --git a/Makefile.objs b/Makefile.objs index 0ba02c7..da31530 100644 --- a/