Re: [Qemu-devel] [PATCH 03/19] avoid dubiously clever code in win32_start_timer

2010-01-04 Thread Paolo Bonzini
On 01/04/2010 08:34 PM, Anthony Liguori wrote: On 12/21/2009 02:09 AM, Paolo Bonzini wrote: The code is initializing an unsigned int to UINT_MAX using "-1", so that the following always-true comparison seems to be always-false at a first look. Just remove the if. This really needs a better com

Re: [Qemu-devel] [PATCH 03/19] avoid dubiously clever code in win32_start_timer

2010-01-04 Thread Anthony Liguori
On 12/21/2009 02:09 AM, Paolo Bonzini wrote: The code is initializing an unsigned int to UINT_MAX using "-1", so that the following always-true comparison seems to be always-false at a first look. Just remove the if. This really needs a better comment message as at first it wasn't obvious to

[Qemu-devel] [PATCH 03/19] avoid dubiously clever code in win32_start_timer

2009-12-21 Thread Paolo Bonzini
The code is initializing an unsigned int to UINT_MAX using "-1", so that the following always-true comparison seems to be always-false at a first look. Just remove the if. Signed-off-by: Paolo Bonzini --- vl.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/vl.c b/