Re: [Qemu-devel] [PATCH 03/13] usb-xhci: Use PCI DMA helper functions

2012-03-22 Thread David Gibson
On Thu, Mar 22, 2012 at 11:00:57AM +0100, Gerd Hoffmann wrote: > Hi, > > > -#include "hw/qdev-addr.h" > > +//#include "hw/qdev-addr.h" > > Minor nit: Just zap it instead of leaving it in commented out. Oops, fixed. > Looks fine otherwise. > > Acked-by: Gerd Hoffmann > > cheers, > Gerd >

Re: [Qemu-devel] [PATCH 03/13] usb-xhci: Use PCI DMA helper functions

2012-03-22 Thread Gerd Hoffmann
Hi, > -#include "hw/qdev-addr.h" > +//#include "hw/qdev-addr.h" Minor nit: Just zap it instead of leaving it in commented out. Looks fine otherwise. Acked-by: Gerd Hoffmann cheers, Gerd

[Qemu-devel] [PATCH 03/13] usb-xhci: Use PCI DMA helper functions

2012-03-21 Thread David Gibson
Shortly before 1.0, we added helper functions / wrappers for doing PCI DMA from individual devices. This makes what's going on clearer and means that when we add IOMMU support somewhere in the future, only the general PCI code will have to change, not every device that uses PCI DMA. However, usb-

[Qemu-devel] [PATCH 03/13] usb-xhci: Use PCI DMA helper functions

2012-03-08 Thread David Gibson
Shortly before 1.0, we added helper functions / wrappers for doing PCI DMA from individual devices. This makes what's going on clearer and means that when we add IOMMU support somewhere in the future, only the general PCI code will have to change, not every device that uses PCI DMA. However, usb-

[Qemu-devel] [PATCH 03/13] usb-xhci: Use PCI DMA helper functions

2012-02-29 Thread David Gibson
Shortly before 1.0, we added helper functions / wrappers for doing PCI DMA from individual devices. This makes what's going on clearer and means that when we add IOMMU support somewhere in the future, only the general PCI code will have to change, not every device that uses PCI DMA. However, usb-