Re: [Qemu-devel] [PATCH 03/13] target-openrisc: Separate of load/store instructions

2013-10-29 Thread Sebastian Macke
On 29/10/2013 3:55 PM, Max Filippov wrote: On Wed, Oct 30, 2013 at 1:36 AM, Sebastian Macke wrote: On 29/10/2013 1:05 PM, Max Filippov wrote: On Tue, Oct 29, 2013 at 11:04 PM, Sebastian Macke wrote: Additional this patch solves a severe bug for the softmmu emulation. The pc has to be saved a

Re: [Qemu-devel] [PATCH 03/13] target-openrisc: Separate of load/store instructions

2013-10-29 Thread Max Filippov
On Wed, Oct 30, 2013 at 1:36 AM, Sebastian Macke wrote: > On 29/10/2013 1:05 PM, Max Filippov wrote: >> >> On Tue, Oct 29, 2013 at 11:04 PM, Sebastian Macke >> wrote: >>> Additional this patch solves a severe bug for the softmmu emulation. >>> The pc has to be saved as these instructions can fail

Re: [Qemu-devel] [PATCH 03/13] target-openrisc: Separate of load/store instructions

2013-10-29 Thread Richard Henderson
On 10/29/2013 02:36 PM, Sebastian Macke wrote: > > The problem is the epcr register in the interrupt routine in which the current > pc must be saved. I assume the epcr register is quite predictable based on the insn stream. One can restore more than just the PC during re-translation. C.f. the s3

Re: [Qemu-devel] [PATCH 03/13] target-openrisc: Separate of load/store instructions

2013-10-29 Thread Sebastian Macke
On 29/10/2013 1:05 PM, Max Filippov wrote: On Tue, Oct 29, 2013 at 11:04 PM, Sebastian Macke wrote: This patch separates the load and store instruction to a separate function. The repetition of the source code can be reduced and further optimizations can be implemented. In this case it checks f

Re: [Qemu-devel] [PATCH 03/13] target-openrisc: Separate of load/store instructions

2013-10-29 Thread Max Filippov
On Tue, Oct 29, 2013 at 11:04 PM, Sebastian Macke wrote: > This patch separates the load and store instruction to a > separate function. > The repetition of the source code can be reduced and further > optimizations can be implemented. > In this case it checks for a zero offset and optimizes it. >

[Qemu-devel] [PATCH 03/13] target-openrisc: Separate of load/store instructions

2013-10-29 Thread Sebastian Macke
This patch separates the load and store instruction to a separate function. The repetition of the source code can be reduced and further optimizations can be implemented. In this case it checks for a zero offset and optimizes it. Additional this patch solves a severe bug for the softmmu emulation.