Re: [Qemu-devel] [PATCH 03/12] dirty-bitmap: Drop unused functions

2017-04-13 Thread John Snow
On 04/13/2017 05:19 AM, Vladimir Sementsov-Ogievskiy wrote: > 13.04.2017 02:40, John Snow wrote: >> >> On 04/12/2017 07:36 PM, Eric Blake wrote: >>> On 04/12/2017 05:47 PM, John Snow wrote: On 04/12/2017 01:49 PM, Eric Blake wrote: > We had several functions that no one was using, a

Re: [Qemu-devel] [PATCH 03/12] dirty-bitmap: Drop unused functions

2017-04-13 Thread Vladimir Sementsov-Ogievskiy
13.04.2017 02:40, John Snow wrote: On 04/12/2017 07:36 PM, Eric Blake wrote: On 04/12/2017 05:47 PM, John Snow wrote: On 04/12/2017 01:49 PM, Eric Blake wrote: We had several functions that no one was using, and which used sector-based interfaces. I'm trying to convert towards byte-based in

Re: [Qemu-devel] [PATCH 03/12] dirty-bitmap: Drop unused functions

2017-04-12 Thread John Snow
On 04/12/2017 07:36 PM, Eric Blake wrote: > On 04/12/2017 05:47 PM, John Snow wrote: >> >> >> On 04/12/2017 01:49 PM, Eric Blake wrote: >>> We had several functions that no one was using, and which used >>> sector-based interfaces. I'm trying to convert towards byte-based >>> interfaces, so it's

Re: [Qemu-devel] [PATCH 03/12] dirty-bitmap: Drop unused functions

2017-04-12 Thread Eric Blake
On 04/12/2017 05:47 PM, John Snow wrote: > > > On 04/12/2017 01:49 PM, Eric Blake wrote: >> We had several functions that no one was using, and which used >> sector-based interfaces. I'm trying to convert towards byte-based >> interfaces, so it's easier to just drop the unused functions: >> >> b

Re: [Qemu-devel] [PATCH 03/12] dirty-bitmap: Drop unused functions

2017-04-12 Thread John Snow
On 04/12/2017 01:49 PM, Eric Blake wrote: > We had several functions that no one was using, and which used > sector-based interfaces. I'm trying to convert towards byte-based > interfaces, so it's easier to just drop the unused functions: > > bdrv_dirty_bitmap_size > bdrv_dirty_bitmap_get_meta

[Qemu-devel] [PATCH 03/12] dirty-bitmap: Drop unused functions

2017-04-12 Thread Eric Blake
We had several functions that no one was using, and which used sector-based interfaces. I'm trying to convert towards byte-based interfaces, so it's easier to just drop the unused functions: bdrv_dirty_bitmap_size bdrv_dirty_bitmap_get_meta bdrv_dirty_bitmap_reset_meta bdrv_dirty_bitmap_meta_gran