Re: [Qemu-devel] [PATCH 03/10] qemu-iotests: make 218 executable

2018-10-05 Thread Eric Blake
On 10/5/18 1:02 PM, Eric Blake wrote: On 10/5/18 12:49 PM, Cleber Rosa wrote: We could add a git pre-commit hook grep'ing for "^#!\ *(/usr/bin/env|/bin/(b?a)?sh)" in the 1st line and then checking the file perms. Good idea.  Probably better to send that as a different patch, right? Yes, s

Re: [Qemu-devel] [PATCH 03/10] qemu-iotests: make 218 executable

2018-10-05 Thread Eric Blake
On 10/5/18 12:49 PM, Cleber Rosa wrote: We could add a git pre-commit hook grep'ing for "^#!\ *(/usr/bin/env|/bin/(b?a)?sh)" in the 1st line and then checking the file perms. Good idea. Probably better to send that as a different patch, right? Yes, separate patch. For that matter, "^#!/"

Re: [Qemu-devel] [PATCH 03/10] qemu-iotests: make 218 executable

2018-10-05 Thread Cleber Rosa
On 10/5/18 9:36 AM, Philippe Mathieu-Daudé wrote: > On 04/10/2018 18:18, Cleber Rosa wrote: >> Commit 990dc39c made all tests executable at the time, but 218 came in >> later, and missing those permissions. >> >> Signed-off-by: Cleber Rosa >> --- >> tests/qemu-iotests/218 | 0 >> 1 file change

Re: [Qemu-devel] [PATCH 03/10] qemu-iotests: make 218 executable

2018-10-05 Thread Philippe Mathieu-Daudé
On 04/10/2018 18:18, Cleber Rosa wrote: > Commit 990dc39c made all tests executable at the time, but 218 came in > later, and missing those permissions. > > Signed-off-by: Cleber Rosa > --- > tests/qemu-iotests/218 | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > mode change 100644 => 1

Re: [Qemu-devel] [PATCH 03/10] qemu-iotests: make 218 executable

2018-10-04 Thread Eric Blake
On 10/4/18 11:18 AM, Cleber Rosa wrote: Commit 990dc39c made all tests executable at the time, but 218 came in later, and missing those permissions. Signed-off-by: Cleber Rosa --- tests/qemu-iotests/218 | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 tests

[Qemu-devel] [PATCH 03/10] qemu-iotests: make 218 executable

2018-10-04 Thread Cleber Rosa
Commit 990dc39c made all tests executable at the time, but 218 came in later, and missing those permissions. Signed-off-by: Cleber Rosa --- tests/qemu-iotests/218 | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 tests/qemu-iotests/218 diff --git a/tests/qemu-io